Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-clicking a file updates whole FileSystem tree #99760

Closed
KoBeWi opened this issue Nov 27, 2024 · 5 comments · Fixed by #100010 or #100012
Closed

Double-clicking a file updates whole FileSystem tree #99760

KoBeWi opened this issue Nov 27, 2024 · 5 comments · Fixed by #100010 or #100012

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Nov 27, 2024

Tested versions

4.4 dev5
The relevant code seems to exist since forever, but I don't remember it being that slow before.

System information

Windows 10.0.19045 - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 32.0.15.6603) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 threads)

Issue description

When you double-click a file, the whole editor freezes for a couple of seconds. Also if you had anything in filter, it will be ignored.
https://github.com/user-attachments/assets/7a9eb54b-8e0a-4345-9605-c878dc4f6e5e
For some reason it might also unfold every folder.

I checked the code and double-clicking makes the dock navigate to the file, which causes update of the whole tree.

Steps to reproduce

  1. Open big project
  2. Double-click a file, preferrably image
  3. Image

Minimal reproduction project (MRP)

N/A

@Mickeon
Copy link
Contributor

Mickeon commented Nov 27, 2024

I don't recall anything like this. Is this a regression?

@KoBeWi
Copy link
Member Author

KoBeWi commented Nov 27, 2024

Doesn't seem to happen in 4.3.

@KoBeWi KoBeWi added this to the 4.4 milestone Nov 27, 2024
@KoBeWi KoBeWi moved this from Unassessed to Bad in 4.x Release Blockers Nov 27, 2024
@matheusmdx
Copy link
Contributor

I was unable to reproduce the engine freeze but the unfolding and the filter ignore was caused by #95107, @KoBeWi

Image

@kitbdev
Copy link
Contributor

kitbdev commented Dec 2, 2024

I've noticed the filters get ignored in many cases, I assume its every time the tree updates. Saving the scene, moving the filesystem dock, changing split mode, changing sorting, and opening a file all cause it.
When in split mode, it only seems to happen to the tree part.
I did not notice the editor freezing though.

@KoBeWi
Copy link
Member Author

KoBeWi commented Dec 3, 2024

The freezing happens only when you have lots of files.
I checked in dev4 and the freeze and filter bug are separate issues (though they share their cause).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
4 participants