Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Fix eip155 v #567

Merged
merged 11 commits into from
Nov 15, 2022
Merged

Fix eip155 v #567

merged 11 commits into from
Nov 15, 2022

Conversation

classicalliu
Copy link
Contributor

@classicalliu classicalliu commented Nov 2, 2022

Related:

v in eth_getTransactionByHash returns signature_v(equals to "0x0" or "0x1") before.

Now, it returns

  • v = chain_id * 2 + 35 + signature_v for EIP155 tx
  • v = 27 + signature_v for others

NOTE:
Need to resync or run update command by ./gw-web3-indexer update

@Flouse Flouse requested review from RetricSu, a team and jjyr November 2, 2022 10:24
@classicalliu classicalliu marked this pull request as draft November 3, 2022 02:06
@classicalliu classicalliu marked this pull request as ready for review November 10, 2022 16:23
packages/api-server/src/db/helpers.ts Outdated Show resolved Hide resolved
packages/api-server/src/db/helpers.ts Outdated Show resolved Hide resolved
packages/api-server/src/db/helpers.ts Show resolved Hide resolved
classicalliu and others added 2 commits November 15, 2022 14:30
Co-authored-by: RetricSu <inneverland2013@gmail.com>
@RetricSu RetricSu merged commit f511003 into main Nov 15, 2022
@RetricSu RetricSu deleted the fix-eip155-v branch November 15, 2022 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] eth_getTransactionByHash returns incorrect v parameter
4 participants