Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of go.opentelemetry.io/otel/sdk/metric ( v.035.0 ) breaks #437

Closed
derkan opened this issue Jan 31, 2023 · 4 comments
Closed

New version of go.opentelemetry.io/otel/sdk/metric ( v.035.0 ) breaks #437

derkan opened this issue Jan 31, 2023 · 4 comments
Labels
☢️ Bug Something isn't working

Comments

@derkan
Copy link

derkan commented Jan 31, 2023

New version of opentelemetry-go/metric v.035.0, breaks this library.

../../../../go/pkg/mod/github.com/gofiber/contrib/otelfiber@v0.0.0-20230130213841-c6c740d3aa61/fiber.go:55:35: meter.SyncFloat64 undefined (type metric.Meter has no field or method SyncFloat64)
../../../../go/pkg/mod/github.com/gofiber/contrib/otelfiber@v0.0.0-20230130213841-c6c740d3aa61/fiber.go:59:38: meter.SyncInt64 undefined (type metric.Meter has no field or method SyncInt64)
../../../../go/pkg/mod/github.com/gofiber/contrib/otelfiber@v0.0.0-20230130213841-c6c740d3aa61/fiber.go:63:39: meter.SyncInt64 undefined (type metric.Meter has no field or method SyncInt64)
../../../../go/pkg/mod/github.com/gofiber/contrib/otelfiber@v0.0.0-20230130213841-c6c740d3aa61/fiber.go:67:41: meter.SyncInt64 undefined (type metric.Meter has no field or method SyncInt64)
@ReneWerner87 ReneWerner87 added ☢️ Bug Something isn't working 💡 Help wanted Extra attention is needed labels Jan 31, 2023
@ReneWerner87
Copy link
Member

but this is not merged yet ? problem is in the dependency or ? what could we do here ?

@ReneWerner87 ReneWerner87 removed the 💡 Help wanted Extra attention is needed label Jan 31, 2023
@derkan
Copy link
Author

derkan commented Jan 31, 2023 •
edited
Loading

Updating to latest release causes error, otherwise with given go.mod has no problem. I've submitted issue for future-proof.

@ReneWerner87
Copy link
Member

not needed
#431
as long as the tests are not green, i will not merge it

@gaby
Copy link
Member

gaby commented Feb 1, 2023

I can take a look at fixing the update. Some of the metrics funcs we are using were removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaby @derkan @ReneWerner87