Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional files to a release #1614

Closed
depado opened this issue Sep 10, 2015 · 17 comments
Closed

Add additional files to a release #1614

depado opened this issue Sep 10, 2015 · 17 comments
Assignees
Labels
🎯 feature Categorizes as related to a new feature status: needs feedback Tell me more about it
Milestone

Comments

@depado
Copy link

depado commented Sep 10, 2015

Hello there.

First of all, great work on the PR thing ! 😄

When I create a relase on Github for a Go program for example, I like to add the compiled binaries for the major platforms (Linux/Darwin/Windows). Although right now on Gogs there is no way to do such a thing. I couldn't find any feature request about that, so I create one.

Is that planned ? Is it not ? Is there a simple way I could add those files without them being always in the repository ?

Thanks a lot ! 👍

@unknwon unknwon added the 🎯 feature Categorizes as related to a new feature label Sep 10, 2015
@unknwon unknwon added this to the 0.7.0 milestone Sep 10, 2015
@unknwon
Copy link
Member

unknwon commented Sep 10, 2015

Thanks your feedback!

@unknwon unknwon changed the title Add additionnal files to a release ? Add additional files to a release Sep 10, 2015
@unknwon
Copy link
Member

unknwon commented Sep 10, 2015

This should be pretty much same as #698 , but I'm kind of confused what was the original purpose of that one, so I'll keep this open. 😄

@depado
Copy link
Author

depado commented Sep 10, 2015

Pretty much, except it could be cool if you could add not only binaries but also any additionnal files.
Thanks a lot you're really reactive ! :D

@unknwon
Copy link
Member

unknwon commented Sep 10, 2015

Yes, attachments is the thing I'm thinking about...

@octacian
Copy link

octacian commented May 2, 2016

I would really appreciate seeing this too. Will be really happy to see this before 0.10 though. In fact, I would look into it my self but am not at all familiar with Go.

@jlprat
Copy link

jlprat commented May 2, 2016

I would also really appreciate this feature! It is extremely useful to be able to attach custom files to the release.

@unknwon unknwon added this to the 0.10.0 milestone May 7, 2016
@unknwon unknwon added the status: await It is time consuming label Jul 23, 2016
@unknwon unknwon modified the milestones: 0.11.0, 0.10.0 Aug 12, 2016
@jhit
Copy link

jhit commented Oct 13, 2016

+1 from me to add this feature.
Wanted to add electron app release binaryies to one of our projects and did realise I can't do it :(

@zoh48gz04
Copy link

+1

@octacian
Copy link

So... is there any chance of this actually happening, @unknwon? There hasn't been a single commit to this repo for almost a month now.... I understand people get busy and have to do others things, but really.

@depado
Copy link
Author

depado commented Nov 16, 2016

@octacian There is now a milestone attributed for this, so I guess it's in the pipe. I'd be the first one to be happy with that feature, but I find it rather uncool to remind @unknwon that there was no commit for a month on the Gogs repo 😞

@octacian
Copy link

@depado I guess that is true. I was just wondering if there was actually progress on this specifically. I understand you could see it as "uncool to remind" the developers of, I was just curious what was going on with Gogs in general. I understand that sometimes open source projects kinda "freeze" at times, people get busy and can't put in much time, or for other reasons. So, sorry if I annoyed anyone, as I said, I was just wondering what was happening with Gogs in general. Oh, and FYI, I wasn't really trying to specifically point out to Unknwon that there hadn't been a commit in a while, more so in general just asking what was going on.

Well, with all that said, I hope I haven't annoyed anyone 😃

I might actually learn Go sometime soon.. 🤔

@saviourofdp
Copy link

A workaround could be to add your binary to the repo itself, then link to its raw view (making sure it's the correct commit url) via the content notes in the release. I realise that might not be appropriate for large binaries but it works for me for small stuff.
capture

@unknwon unknwon removed the status: await It is time consuming label Mar 13, 2017
@unknwon unknwon self-assigned this Mar 13, 2017
unknwon added a commit that referenced this issue Mar 13, 2017
Added new config section '[release.attachment]’.
@unknwon unknwon added the status: needs feedback Tell me more about it label Mar 13, 2017
@unknwon
Copy link
Member

unknwon commented Mar 13, 2017

Patch has pushed to fix this issue, please test on develop branch or https://try.gogs.io/unknwon/hello/releases.

@jhit
Copy link

jhit commented Mar 13, 2017

Looks great to me. Does exactly what I need.

@unknwon unknwon closed this as completed Mar 14, 2017
@depado
Copy link
Author

depado commented Mar 15, 2017

Amazing, thanks 👍 🎉

@octacian
Copy link

Thanks so much! I'll give this a try in a few days after i get home.

@melochale
Copy link

Wow, this it most wonderful feature! I cannot wait any more!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎯 feature Categorizes as related to a new feature status: needs feedback Tell me more about it
Projects
None yet
Development

No branches or pull requests

8 participants