Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testability strategy #2293

Open
ayr-ton opened this issue Dec 27, 2015 · 6 comments
Open

Testability strategy #2293

ayr-ton opened this issue Dec 27, 2015 · 6 comments
Labels
⛔ do not send pull request Don't ever think about it! status: await It is time consuming

Comments

@ayr-ton
Copy link

ayr-ton commented Dec 27, 2015

Hey there.

I was digging into the code and saw a excellent piece of work from all the contributors everywhere.

However, something caught my attention. The code base is growing every day but there's no Unit Tests mention at the CONTRIBUTING.md file. As Go has a good built-in support for automated tests (https://golang.org/pkg/testing/) I would like to ask if you guys have plans to design a testing strategy as something required for future contributions.

It could increase confidence in recommending the project for production use as well, as I think gogs could replace a lot of solutions out there.

Also, I can see there's a few modules with tests https://github.com/gogits/gogs/search?p=1&q=testing&utf8=%E2%9C%93 but the coverage still small.

If you 👍 this idea, we can discuss here the strategy.

@unknwon
Copy link
Member

unknwon commented Dec 27, 2015

Yes, unit tests can only be applied to small part of Gogs's codebase.

I'm waiting to finish APIs to achieve more on testing.

@unknwon
Copy link
Member

unknwon commented Dec 27, 2015

Also, I suggest move discussion to http://forum.gogs.io/

@unknwon unknwon added the status: needs feedback Tell me more about it label Dec 27, 2015
@unknwon unknwon added this to the 0.9.0 milestone Dec 27, 2015
@unknwon
Copy link
Member

unknwon commented Jan 1, 2016

ping @ayr-ton ?

@ayr-ton
Copy link
Author

ayr-ton commented Jan 5, 2016

Pong @unknwon
I will be moving the discussion to the forum and then I will be posting the results here :)

@ayr-ton
Copy link
Author

ayr-ton commented Jan 5, 2016

@unknwon unknwon added the status: await It is time consuming label Jan 5, 2016
@tebanep
Copy link

tebanep commented Jan 30, 2016

Happened exactly the same to me, when looking for tests. Hope an strategy can be set so the confidence in the program increases. Though, I'm using gogs in production right now without problems. Thanks for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔ do not send pull request Don't ever think about it! status: await It is time consuming
Projects
None yet
Development

No branches or pull requests

3 participants