-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc contextPkgPath should use "context" #390
Comments
I am going to wait for golang/protobuf to fix this first |
ok |
Sorry that this issue has been delayed for so long. |
Hi @awalterschulze, golangprotobuf have already merged fix. |
Yes it has been merged into their |
FYI, it's been reverted again... see golang/protobuf#580. |
whop whop :) Thank you for pushing @dsnet |
Note that support for Go 1.6 is orthogonal to which context package is imported. We should not change grpc or its plugin to import "context" until 1.9 is the oldest supported version (for type aliases). Also note that anyone using Go 1.9 or later shouldn't care how context is imported. |
As of Go 1.7 this package(
golang.org/x/net/context
) is available in the standard library under the name context. https://golang.org/pkg/context. So we should replace grpc contextPkgPath golang.org/x/net/context with contextThe text was updated successfully, but these errors were encountered: