Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Harbor translations #16321

Closed
4 of 8 tasks
a-mccarthy opened this issue Feb 1, 2022 · 16 comments
Closed
4 of 8 tasks

Verify Harbor translations #16321

a-mccarthy opened this issue Feb 1, 2022 · 16 comments
Labels
help wanted The issues that is valid but needs help from community Stale

Comments

@a-mccarthy
Copy link

a-mccarthy commented Feb 1, 2022

Describe the solution you'd like

We have a lot of community contributor translations for the Habror portal, https://github.com/goharbor/harbor/tree/main/src/portal/src/i18n/lang. We should go through each translations and make sure that they are correct and updated for the most recent version of Harbor.

Describe the main design/architecture of your solution

We should reach out to the Harbor community to see of folks are able to validate the current translation files.

Checklist of languages to validate:

Ask to community:
If you are fluent in any of the above languages, please review the file for your language and verify that the content is correct or open a PR with any changes.

Related links

@a-mccarthy a-mccarthy added the help wanted The issues that is valid but needs help from community label Feb 1, 2022
@a-mccarthy
Copy link
Author

It looks like the files for the translations have been update with the current UI fields as they were added to the Harbor portal UI. They were added in English, mixed in with the previously translated fields.

More info on how translations within the harbor portal ui work can be found here: https://goharbor.io/docs/2.4.0/build-customize-contribute/developer-guide-i18n/

@a-mccarthy
Copy link
Author

@Vad1mo Here's the issue for validating the Harbor interface localizations. Thanks for offering to help with German. Please tag anyone else you thinking might be willing to help :)

@Vad1mo
Copy link
Member

Vad1mo commented Feb 23, 2022

@sluetze Harbor has code freeze for 2.5, so I guess it's safe that we look at the german translation. should we setup a session for next week?

@sluetze
Copy link
Contributor

sluetze commented Feb 23, 2022

Sure, will reach out on slack tomorrow.

@a-mccarthy
Copy link
Author

thank you @sluetze and @Vad1mo for working on this!

Do you have any ideas or suggestions on how we can track wording changes that will need to be translated going forward?

@Vad1mo
Copy link
Member

Vad1mo commented Mar 16, 2022

track wording changes

This is not clear to me, can you elaborate about the goal you are trying to achieve?

Normally we look at all the text snippets that are not translated and translate them.

@a-mccarthy
Copy link
Author

@Vad1mo I'm just wondering if its possible to keep track of updates to the interface that would need to be translated. For example, if there is a PR that updates the interface text, then we should make an issue to track that translation work is needed? Or, should we just do a check around release time to see if anything has been updated and translate it then?

I'm trying to think about translation needs going forward to see if we can make this process easier for folks to know when we need help, and I was interested to see if y'all had any ideas :)

@Vad1mo
Copy link
Member

Vad1mo commented Mar 16, 2022

  • So we rarely change existing text, it is mostly only added.
  • When Devs add a text, they copy & paste it to all language files in English.
  • When we look at the language file, we look at the changes between the releases.

So I would say that for the moment it is enough to ping all the translation responsible people before the release and ask them to take a look and update the lang file.

@sluetze
Copy link
Contributor

sluetze commented Mar 16, 2022

alternative would be to ping the people when changes are made to the file and make language-specific changes directly. But this would slow down the developers (since they would be dependent on translators) and would result in duplicate work as translator, since sometimes there is more than one language-change in a release. So this is a bad idea. a ping a few days/weeks before code-freeze should be sufficient.

@a-mccarthy
Copy link
Author

ok, thanks for the feedback @Vad1mo and @sluetze! we'll stick with checking for updates around release time 🚀

@Vad1mo
Copy link
Member

Vad1mo commented Mar 17, 2022

@a-mccarthy, there is #16524 open for FR translation. According to google translate and my minimal French the translation seems reasonable and definitely better than the status quo

@a-mccarthy
Copy link
Author

The french translation was updated in this PR: #16570 🚀

@github-actions
Copy link

github-actions bot commented Jul 5, 2022

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Jul 5, 2022
@AllForNothing
Copy link
Contributor

Keep it open so that the community can continue to contribute

@github-actions
Copy link

github-actions bot commented Nov 1, 2022

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label Nov 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The issues that is valid but needs help from community Stale
Projects
None yet
Development

No branches or pull requests

6 participants