Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan only images that were pulled within predefined time frame #17125

Open
dkulchinsky opened this issue Jul 6, 2022 · 9 comments
Open

Scan only images that were pulled within predefined time frame #17125

dkulchinsky opened this issue Jul 6, 2022 · 9 comments
Assignees
Labels
area/vulnerability-scan kind/requirement New feature or idea on top of harbor

Comments

@dkulchinsky
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Our Harbor registry has 7 projects and over 100,000 image tags across ~1,000 repos.

In the past we relied on the SCAN_ALL job to ensure that the vulnerability reports are up to date, however as our registry grew the SCAN_ALL job simply doesn't scale, it can take several days to scan all the images and also resulted in few incidents where it caused the registry to stall.

Describe the solution you'd like
We would like to see more controls on how the SCAN_ALL runs (or an additional SCAN job that provides more controls), specifically:

  1. Scan only image tags that were pulled within a provided duration (e.g. last 30 days), avoid scanning stale/old images
  2. Introduce filters to select which projects to scan (or skip)
  3. Introduce filters to select which repos to scan (or skip)

The above expands what I proposed in #15652 but never received any meaningful feedback on.

Describe the main design/architecture of your solution
I think the above illustrates well what is needed.

Describe the development plan you've considered
Not sure how to answer that.

Additional context
Add any other context or screenshots about the feature request here.

@dkulchinsky dkulchinsky changed the title Scan all images that were pulled within predefined timeframe Scan only images that were pulled within predefined time frame Jul 6, 2022
@wy65701436 wy65701436 added kind/requirement New feature or idea on top of harbor area/vulnerability-scan labels Jul 7, 2022
@OrlinVasilev
Copy link
Member

added to 2.7 requirement collection! #16775

@EdKingscote
Copy link

Being able to configure scanning rules as part of the project policies alongside retention and immutability would be awesome.

@qnetter
Copy link
Contributor

qnetter commented Sep 13, 2022

I think it is a worthwhile addition but will not fit in 2.7 unless someone in the community volunteers to work on it.

@dkulchinsky
Copy link
Contributor Author

I think it is a worthwhile addition but will not fit in 2.7 unless someone in the community volunteers to work on it.

that's a shame, according to @OrlinVasilev this was flagged for 2.7, what has chnaged?

@qnetter
Copy link
Contributor

qnetter commented Sep 13, 2022

It was flagged as a 2.7 candidate, not as a commitment. The 2.7 development window is shorter than usual because of China and US holiday closures during this period between now and end of year.

@dkulchinsky
Copy link
Contributor Author

It was flagged as a 2.7 candidate, not as a commitment. The 2.7 development window is shorter than usual because of China and US holiday closures during this period between now and end of year.

I see, thanks for clarifying.

Is there a list of enhancements that were committed to 2.7? I couldn't see that in the discussion issue

Also, looks like this specific item is one of the most voted one, so was hoping it would get prioritized accordingly.

@qnetter
Copy link
Contributor

qnetter commented Sep 13, 2022

I should correct myself - it is still on the 2.7 list, but at low priority so may fall off if we run out of time.

I will update the visible list shortly.

@dkulchinsky
Copy link
Contributor Author

@qnetter @OrlinVasilev This was originally flagged to be added to 2.7 roadmap, but looks like never made the cut.

Is this is still being considered?

@OrlinVasilev
Copy link
Member

@dkulchinsky we are a bit short on hands to take all new requirements and features!
can you please add it in the discussion and if you feel like developing it :) there are few new proposal in the community repository about scanning you can check them as well ! :) THanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vulnerability-scan kind/requirement New feature or idea on top of harbor
Projects
None yet
Development

No branches or pull requests

6 participants