Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native support for the Pangu plugin #10617

Open
cmpute opened this issue Jan 12, 2023 · 3 comments
Open

Native support for the Pangu plugin #10617

cmpute opened this issue Jan 12, 2023 · 3 comments
Labels
Milestone

Comments

@cmpute
Copy link

cmpute commented Jan 12, 2023

I'm not sure if anybody has brought this up but I just wish this feature could be supported. Pangu is a module that automatically insert spaces between CJK characters and Latin characters, which is very useful to increase readability of some text mixed with CJK and Latin characters. It has been implemented in several languages including Go and JS.

This plugin has been widely used by blog themes, but they all rely on the javascript version. It makes sense to me to support it natively in Hugo, so that the process is done during building instead of browsing.

@bep bep removed the NeedsTriage label Jan 13, 2023
@bep bep added this to the v0.109.0 milestone Jan 13, 2023
@bep
Copy link
Member

bep commented Jan 13, 2023

@cmpute thanks for this. Realistically, I think this would need to be implemented in Goldmark. They already have a CJK extension (see #10472), but I'm not sure exactly what that does, but I would start there. The maintainer of Goldmark is very attentive and open to suggestions.

@cmpute
Copy link
Author

cmpute commented Jan 13, 2023

Thank for the info, I posted a request in Goldmark: yuin/goldmark#351

@bep bep modified the milestones: v0.109.0, v0.111.0 Jan 26, 2023
@bep bep modified the milestones: v0.111.0, v0.112.0 Feb 15, 2023
@cathaysia
Copy link

native support this is not a good idea. pangu may insert some bad space around content.

@bep bep modified the milestones: v0.112.0, v0.113.0 Apr 15, 2023
@bep bep modified the milestones: v0.113.0, v0.115.0 Jun 13, 2023
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 5, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@bep bep modified the milestones: v0.121.0, v0.122.0 Dec 6, 2023
@bep bep removed this from the v0.122.0 milestone Jan 27, 2024
@bep bep modified the milestones: v0.123.0, v0.124.0 Jan 27, 2024
@bep bep modified the milestones: v0.124.0, v0.125.0 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants