Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing images doesn't work when fingerprinting #6284

Closed
earthboundkid opened this issue Aug 30, 2019 · 3 comments
Closed

Resizing images doesn't work when fingerprinting #6284

earthboundkid opened this issue Aug 30, 2019 · 3 comments

Comments

@earthboundkid
Copy link
Contributor

I have the following snippet in a partial used for a page bundle:

      {{ with index (.Resources.ByType "image") 0  }}
        {{ $img := . }}
        {{ $imgSmall := .Resize "350x" | fingerprint }}
        <figure class="image">
          <img
            alt="{{ $img.Title }}"
            src="{{ $imgSmall.RelPermalink }}"
          >
        </figure>
      {{ end}}

I found that it's not resizing the image unless I remove | fingerprint.

@earthboundkid
Copy link
Contributor Author

$ hugo version
Hugo Static Site Generator v0.57.2/extended darwin/amd64 BuildDate: unknown

Brew installed.

@bep bep added this to the v0.58 milestone Sep 2, 2019
@bep
Copy link
Member

bep commented Sep 2, 2019

I will check; I'm pretty sure this is fixed in the latest source, but I'll add a test for it. But note that fingerprinting resized images for "cache busting" is not needed -- as their filename will change when the image changes.

@bep bep closed this as completed in 45d7988 Sep 2, 2019
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants