Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

Please add Elate theme #187

Closed
saey55 opened this issue Nov 18, 2016 · 4 comments
Closed

Please add Elate theme #187

saey55 opened this issue Nov 18, 2016 · 4 comments

Comments

@saey55
Copy link

saey55 commented Nov 18, 2016

Hello,

I've created my 1st theme for Hugo: https://github.com/saey55/hugo-elate-theme
Could you please add it to the themes page?
In case anything is off or missing, please let me know.

Regards,
Saey55

@digitalcraftsman
Copy link
Member

Hello

thank you for sharing the theme with the Hugo community. Your theme looks fine except this minor issue: images/screenshot.png doesn't have the right dimensions (it seems you accidently mixed them).

Otherwise, you're theme is ready to be added.

@saey55
Copy link
Author

saey55 commented Nov 18, 2016

Hello,

I've resized the images.
You can always provide more feedback since it's my 1st contribution to this nice community.

@digitalcraftsman
Copy link
Member

You can always provide more feedback since it's my 1st contribution to this nice community.

I browsed your templates and everything looks fine. It seems you got inspiration from certain themes 😉

The Agency theme was one of the first I ported, which is also a single-page theme. The config file grew rather long and today I would have moved some if the options into data files. However, since the theme is quite popular I try to ensure compatibility instead of messing up everyone's website. The status quo is not bad - a flat config file would just be easier to understand.

@saey55
Copy link
Author

saey55 commented Nov 18, 2016

Hello,

Thanks for reviewing this. I will take your feedback concerning the data files into account.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants