-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests for game package functions #7
Comments
Maybe would be nice to split more the functionalities in a different files, bc the game.go has a lot of responsibility now and it's hard to test all bc are too coupled. |
@charly3pins do you want to take this up ? |
its a pretty major refactoring to do what @charly3pins. One of the biggest difficulties i encountered doing #25 was the game |
@dskoda1 will take a look into this. |
Oh I didn't see this issue, sorry if someone already picked it up, I noticed there was panic on isWon, I created unit test while fixing it, see #27 I noticed the logic of the game is coupled with the logic of drawing, My recommendation is to split that for testability |
No description provided.
The text was updated successfully, but these errors were encountered: