Skip to content

Commit

Permalink
internal/gomote: add ListDirectoryStreaming RPC
Browse files Browse the repository at this point in the history
ListDirectory responses can overflow the maximum RPC message size.
Add a streaming version which returns its results in chunks.

For golang/go#69732

Change-Id: I3f7d50a3899f0cbc9954da89a26906f1f5850a93
Reviewed-on: https://go-review.googlesource.com/c/build/+/617160
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
  • Loading branch information
neild committed Oct 2, 2024
1 parent 785db46 commit d74ce56
Show file tree
Hide file tree
Showing 5 changed files with 213 additions and 98 deletions.
144 changes: 76 additions & 68 deletions internal/gomote/protos/gomote.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions internal/gomote/protos/gomote.proto
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ service GomoteService {
rpc InstanceAlive (InstanceAliveRequest) returns (InstanceAliveResponse) {}
// ListDirectory lists the contents of a directory on an gomote instance.
rpc ListDirectory (ListDirectoryRequest) returns (ListDirectoryResponse) {}
// ListDirectoryStreaming lists the contents of a directory on an gomote instance.
rpc ListDirectoryStreaming (ListDirectoryRequest) returns (stream ListDirectoryResponse) {}
// ListInstances lists all of the live gomote instances owned by the caller.
rpc ListInstances (ListInstancesRequest) returns (ListInstancesResponse) {}
// ListSwarmingBuilders lists all of the swarming builders for the project.
Expand Down
Loading

0 comments on commit d74ce56

Please sign in to comment.