From 0fc4c6147d47b3c2a9e001502eefa6617d8350a5 Mon Sep 17 00:00:00 2001 From: Denis Brodbeck Date: Fri, 20 Oct 2017 22:33:49 +0200 Subject: [PATCH 1/3] Append .exe to windows builds when creating release. --- hack/build-all.bash | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hack/build-all.bash b/hack/build-all.bash index 45f8cf2476..271bf8b469 100755 --- a/hack/build-all.bash +++ b/hack/build-all.bash @@ -29,9 +29,13 @@ mkdir -p release for OS in ${DEP_BUILD_PLATFORMS[@]}; do for ARCH in ${DEP_BUILD_ARCHS[@]}; do + NAME="dep-$OS-$ARCH" + if [ "$OS" == "windows" ]; then + NAME="$NAME.exe" + fi echo "Building for $OS/$ARCH" GOARCH=$ARCH GOOS=$OS CGO_ENABLED=0 $GO_BUILD_CMD -ldflags "$GO_BUILD_LDFLAGS"\ - -o "release/dep-$OS-$ARCH" ./cmd/dep/ - shasum -a 256 "release/dep-$OS-$ARCH" > "release/dep-$OS-$ARCH".sha256 + -o "release/$NAME" ./cmd/dep/ + shasum -a 256 "release/$NAME" > "release/$NAME".sha256 done done From c72ba3ab43bf89b414011773c2aec3baf0da6c45 Mon Sep 17 00:00:00 2001 From: Denis Brodbeck Date: Fri, 20 Oct 2017 22:49:05 +0200 Subject: [PATCH 2/3] Update changelog. --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 205176316d..34b75e2e60 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # v0.3.3 (Unreleased) +BUG FIXES: + +* Releases targeting Windows now have a `.exe` suffix (#1291). # v0.3.2 From 9b1caaac06d30a68c7060d2204a3c43646529ee1 Mon Sep 17 00:00:00 2001 From: Denis Brodbeck Date: Mon, 23 Oct 2017 10:22:07 +0200 Subject: [PATCH 3/3] Add .exe to travis file. --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index ff197a23e7..4d3995772a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -66,8 +66,8 @@ jobs: - release/dep-linux-amd64.sha256 - release/dep-darwin-amd64 - release/dep-darwin-amd64.sha256 - - release/dep-windows-amd64 - - release/dep-windows-amd64.sha256 + - release/dep-windows-amd64.exe + - release/dep-windows-amd64.exe.sha256 skip_cleanup: true on: repo: golang/dep