Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Use default prune settings during dep init #1404

Closed
carolynvs opened this issue Nov 27, 2017 · 8 comments
Closed

Use default prune settings during dep init #1404

carolynvs opened this issue Nov 27, 2017 · 8 comments

Comments

@carolynvs
Copy link
Collaborator

carolynvs commented Nov 27, 2017

Now that prune is (almost) absorbed into ensure, dep init should set some safe prune defaults on the generated manifest. init should also apply the prune options against vendor.

[prune]
  go-tests = true
  unused-packages = true

See #952 and #1226 for context.

@arbourd
Copy link
Contributor

arbourd commented Dec 5, 2017

I can pick this one up if no one else wants it. 😁

@carolynvs
Copy link
Collaborator Author

It's all yours 🎁

@sdboyer sdboyer added this to the v0.4.0 milestone Dec 6, 2017
@sdboyer
Copy link
Member

sdboyer commented Dec 6, 2017

definitely want to have this one before we release v0.4.0 - what dep init does will define a standard behavior that folks will follow. a sane default is key.

@arbourd
Copy link
Contributor

arbourd commented Dec 11, 2017

Hey folks, just wanted to drop a quick update. Still planning on getting to this one by the end of this upcoming week/weekend. My original plan was this past weekend but I've been sick 🤒

If this blocking v0.4.0 and someone wants to get it done it before this week, feel free to take it. 🤓

@carolynvs
Copy link
Collaborator Author

Feel better!

Also I've updated the OP with the desired default prune settings.

@arbourd
Copy link
Contributor

arbourd commented Dec 14, 2017

Excellent! Thank you. That was what I was thinking too -- non-go might be a little over the top for a default setting. 😃

@sdboyer
Copy link
Member

sdboyer commented Jan 3, 2018

@carolynvs we're just keeping this open until we merge the pending prune branch, right?

@carolynvs
Copy link
Collaborator Author

It's just how github works. It doesn't auto-close an issue when a PR is merged into the non-default branch. So once the release branch is merged, then all the issues will be closed.

@sdboyer sdboyer closed this as completed Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants