-
Notifications
You must be signed in to change notification settings - Fork 1k
dep should prune testdata directories if go-tests pruner is enabled #1580
Comments
huh, interesting. i would've figured it removed those, unless an actual import points into them. /cc @ibrasho |
In case you want to inspect, I made a branch with the change I described here: https://github.com/ixdy/kubernetes-repo-infra/tree/dep-testdata-dir |
Ah yeah, i suspect our deletion logic is being tripped up by the circular symlinks. Yeah...really should get rid of those. hmm. |
@sdboyer Actually, this is not related to the circular symlinks. If we made |
I guess I argued for the wrong pruner, originally. I suspect that having Instead, I would expect that setting
It thus should be safe to remove it if all tests are also removed. |
@ibrasho ohh right. god, symlinks. we really need to keep better notes on these conversations we have about them 😢
that's an interesting point. now, it can't be entirely unconditional, but it seems like we should be able to incorporate something like that under the |
@sdboyer I really should get to documenting how we handle symlinks in general... If |
(belated answer)
Because it's (annoyingly) allowed to have an import statement that points into a Fortunately, once we stop just stop exporting symlinks, i think things will get a lot easier. |
Is this still planned? If not, for anyone else with this problem you can wrap dep in a thin script that |
Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks! |
What version of
dep
are you using (dep version
)?v0.4.1
What
dep
command did you run?I updated
Gopkg.toml
to vendor thedep
command and to prune everything nonessential:I then ran
dep ensure
.What did you expect to see?
All non-used files and directories removed.
What did you see instead?
dep
left the testdata directory invendor/github.com/golang/dep/internal/fs
, even though it's not used.The infinite symlinks in this directory are causing problems for Bazel as described in #1412 (comment).
The text was updated successfully, but these errors were encountered: