This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Restore warning logging from #528 #531
Labels
Comments
|
updating to note that i won't have time to get to to this tonight, so someone else should please feel free 😄 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#528 added warnings when the manifest contained invalid data, but a logical conflict with #525 (which removed global loggers) caused an error that wasn't caught by tests b/c they were merged in rapid succession. And so, we had #530.
This issue is for restoring that warning. It'll likely be a bit involved -
*Loggerswill need to be injected a fair ways up the chain, possibly intodep.Ctx+NewContext(), so that those warning messages can be restored.This is pretty important to tackle quickly; I'll take care of it tonight if someone else doesn't get to it first.
The text was updated successfully, but these errors were encountered: