Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Require Go 1.8 for dep #757

Closed
sdboyer opened this issue Jun 15, 2017 · 2 comments
Closed

Require Go 1.8 for dep #757

sdboyer opened this issue Jun 15, 2017 · 2 comments

Comments

@sdboyer
Copy link
Member

sdboyer commented Jun 15, 2017

Right now, we retain support for Go 1.7. The main pain point this causes is that we have a bunch of junk sorting types, just itching to be replaced by sort.Slice().

I'd like to replace these once we think it's safe to do so. One reasonable measure for "safe" could be the state of the RHEL repositories (or at least EPEL). CentOS seems to have 1.6, and RHEL none at all; EPEL has 1.7, assuming I'm doing that search right.

@timothysc
Copy link

timothysc commented Jun 15, 2017

I'd absolutely never depend on a distros version of golang unless you want to be sorely disappointed. I create a clean GOPATH and vendor my deps and use https://github.com/travis-ci/gimme to manage my golang versions.

As an ex-hatter this is how we managed our own non-containerized builds. For containerized builds, this just goes away...

I'd say just pull the trigger.

@sdboyer sdboyer closed this as completed Aug 28, 2017
@sdboyer
Copy link
Member Author

sdboyer commented Aug 28, 2017

now that 1.9 is out, doing this is fine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants