Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

"panic: version queue is empty, should not happen" while trying to use "develop" branch of "github.com/gin-gonic/gin" #776

Closed
andreynering opened this issue Jun 20, 2017 · 7 comments · Fixed by #1243

Comments

@andreynering
Copy link

What version of Go (go version) and dep (git describe --tags) are you using?

$ go version
go version go1.8 windows/386
$ git describe --tags
v0.1.0-175-gc79b048

Description

I first run dep init -v. Here the files:

Dep automatically choose the default branch of Gin project (master), but I need develop. So I changed Gopkg.toml from:

[[constraint]]
  name = "github.com/gin-gonic/gin"
  version = "1.1.4"

To:

[[constraint]]
  branch = "develop"
  name = "github.com/gin-gonic/gin"

Then I runned dep ensure and got the panic.

@carolynvs
Copy link
Collaborator

Seems like the root problem is that https://github.com/gin-contrib/sse doesn't have any tags or branches with version names. dep isn't handling gopkg.in's Version Zero correctly, which should resolve to the default branch.

@carolynvs
Copy link
Collaborator

I'm going to work on this (and #777) as they are both related to how we sort/resolve gopkg.in versions.

@ibrasho
Copy link
Collaborator

ibrasho commented Sep 21, 2017

@carolynvs Is this resolved by #1053?

@carolynvs carolynvs removed their assignment Sep 21, 2017
@carolynvs
Copy link
Collaborator

Nice catch, yes it has! dep now picks the default branch instead of panicing:

(44)  ? attempt github.com/gin-contrib/sse with 1 pkgs; 1 versions to try
(47)      try github.com/gin-contrib/sse@master
(47)  ✓ select github.com/gin-contrib/sse@master w/1 pkgs

@sdboyer
Copy link
Member

sdboyer commented Sep 22, 2017

phew, I saw this come up in my notifications and thought we had a regression 😅

@carolynvs carolynvs reopened this Oct 6, 2017
@carolynvs
Copy link
Collaborator

I screwed up validating this was fixed (I used github.com instead of gopkg.in in the import path). Reopening...

@bennyscetbun
Copy link

bennyscetbun commented Nov 20, 2017

hi there,
any eta fixing the issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants