Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Improve revision detection in DeduceConstraint #800

Closed
carolynvs opened this issue Jul 6, 2017 · 1 comment
Closed

Improve revision detection in DeduceConstraint #800

carolynvs opened this issue Jul 6, 2017 · 1 comment

Comments

@carolynvs
Copy link
Collaborator

DeduceConstraint currently uses a simple check to determine if a string is a revision. But we can do better!

By moving this into *sourceMgr, we create an opportunity to do better validation here. Rather than deducing whether it's a revision from what general rules we have about the patterns of the bytes, we can actually hand this off to a sourceGateway, which can validate that it's an appropriate revision for that source type.

https://github.com/golang/dep/pull/761/files#r122593455


This is for after #761 is merged, which moves DeduceConstraint from the ensure command into SourceManager. Also note that #715 also touches the function, so waiting for that to settle down would be best.

@carolynvs
Copy link
Collaborator Author

Closing this in favor of #987

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants