Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Windows release file is named dep-windows-amd64 instead of dep-windows-amd64.exe #1291

Closed
denisbrodbeck opened this issue Oct 20, 2017 · 2 comments · Fixed by #1292
Closed

Windows release file is named dep-windows-amd64 instead of dep-windows-amd64.exe #1291

denisbrodbeck opened this issue Oct 20, 2017 · 2 comments · Fixed by #1292
Labels
bug good first issue help wanted
Milestone
v0.4.0

Comments

@denisbrodbeck
Copy link
Contributor

The release tab on github links windows binaries. These links are named wrongly. After downloading, I have to rename dep-windows-amd64 into dep-windows-amd64.exe in order to use the binary.

Releases targeting Windows should have a .exe suffix.

What version of dep are you using (dep version)?

v0.3.2-4-g7b5c43a

What did you expect to see?

The name should be dep-windows-amd64.exe.

What did you see instead?

The name of the file is dep-windows-amd64.
@denisbrodbeck denisbrodbeck mentioned this issue Oct 20, 2017
Merged
@darkowlzz darkowlzz added this to the v0.3.3 milestone Oct 22, 2017
@bpicode bpicode mentioned this issue Oct 22, 2017
Closed
@ebati
Copy link
Contributor

ebati commented Oct 23, 2017

Can you please add exe extension to travis file ( here )

@denisbrodbeck
Copy link
Contributor Author

@ebati Added it to the travis file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

Releases targeting Windows now have a .exe suffix
4 participants
@denisbrodbeck @darkowlzz @carolynvs @ebati