From 53c91f9205e2b61d972ab1eaf5c9716aabe10306 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Fri, 10 Mar 2023 14:21:01 -0500 Subject: [PATCH] os: skip TestExecutableDeleted earlier when 'go build' is not supported The test unconditionally calls testenv.GoToolPath, which will skip the test anyway. Moving the skip earlier gets this test out of goroutine dumps if the test process fails or times out, making it easier to diagnose failures in the remaining tests. Change-Id: Ibd39546708a83b6f15616b2c4ae7af420e2401f0 Reviewed-on: https://go-review.googlesource.com/c/go/+/475455 TryBot-Result: Gopher Robot Auto-Submit: Bryan Mills Run-TryBot: Bryan Mills Reviewed-by: Ian Lance Taylor --- src/os/executable_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/os/executable_test.go b/src/os/executable_test.go index 8d1794d3400e3..c835bb436baa0 100644 --- a/src/os/executable_test.go +++ b/src/os/executable_test.go @@ -89,7 +89,7 @@ func init() { } func TestExecutableDeleted(t *testing.T) { - testenv.MustHaveExec(t) + testenv.MustHaveGoBuild(t) switch runtime.GOOS { case "windows", "plan9": t.Skipf("%v does not support deleting running binary", runtime.GOOS)