cmd/go: go install complains that GOBIN is not set when GOBIN is, in fact, set

[NoraCodes]

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.8.3 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN="/usr/local/bin"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build096398507=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?

I ran go install in a Dockerfile. GOBIN is set to /usr/local/bin, as evinced by:

$ docker run --rm -it 8e6d5915607c bash -c "echo \$GOBIN"
/usr/local/bin

What did you expect to see?

I expected go install to put binaries in /usr/local/bin

What did you see instead?

Step 9/11 : RUN go install /go/src/github.com/<censored path>.go &&     go install /go/src/github.com/<censored path>.go
 ---> Running in 78ed3055447b
go install: no install location for .go files listed on command line (GOBIN not set)
The command '/bin/sh -c go install /go/src/github.com/<censored path>.go &&     go install /go/src/github.com/<censored path>.go' returned a non-zero code: 1

[ianlancetaylor]

Works for me in a simple test.

Please show us the complete steps to reproduce the problem.

[NoraCodes]

Here's the Dockerfile, again somewhat censored (sorry about that):

FROM golang:1.8
RUN <censored; sets up /etc, doesn't touch anything Go cares about>
VOLUME /backplane
VOLUME /private

ENV GOBIN=/usr/local/bin

COPY docker-entrypoint.sh /
COPY provision-soa-service /usr/local/bin
COPY . /go/src/github.com/<censored>/ship-modules/go/shipmodule-service

RUN go install /go/src/github.com/<censored>/ship-modules/go/shipmodule-service/shipmodule_service.go && \
    go install /go/src/github.com/<censored>/ship-modules/go/shipmodule-service/vendor/github.com/<censored>/scamp-go/bin/scamp.go 
    # uncomment following lines to remove source code from container after build
    # && \
    # rm -rf /go/src/*

ENTRYPOINT ["/docker-entrypoint.sh"]
CMD ["shipmodule_service", "-config", "<censored>"]

[saljam]

Are all of these packages 'main' packages? go install complains like this if you try to install a non-main package while directly referencing the . go files. See #8424.

Minimal Dockerfile to reproduce this without the censored stuff:

FROM golang:1.8

# s/package hello/package main/ for it to succeed.
RUN echo 'package hello; func main(){println("hello")}' > /hello.go

ENV GOBIN=/usr/local/bin
RUN go install /hello.go

[NoraCodes]

That does appear to be the root issue. Thanks for identifying it.