Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: directory traversal in "go get" via curly braces in import paths [Go 1.10] #29236

Closed
FiloSottile opened this issue Dec 13, 2018 · 2 comments
Closed

cmd/go: directory traversal in "go get" via curly braces in import paths [Go 1.10] #29236

FiloSottile opened this issue Dec 13, 2018 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Milestone
Go1.10.6

Comments

@FiloSottile
Copy link
Contributor

This is a tracking issue for #29231, a security vulnerability fixed in Go 1.10.6.
@FiloSottile FiloSottile added this to the Go1.10.6 milestone Dec 13, 2018
@pgaskin
Copy link

pgaskin commented Dec 13, 2018

This breaks go getting with ...: https://travis-ci.com/geek1011/kobopatch-patches/builds/94712529#L523.

This is because you just do a simple check for if a path contains .., without accounting for the ....

@FiloSottile FiloSottile changed the title cmd/go: directory traversal via curly braces in import paths [Go 1.10] cmd/go: directory traversal in "go get" via curly braces in import paths [Go 1.10] Dec 13, 2018
@FiloSottile FiloSottile mentioned this issue Dec 13, 2018
Closed
@FiloSottile
Copy link
Contributor Author

Thanks for reporting this, I opened #29241 and we'll work to fix this as soon as possible.

@dmitshur dmitshur added the CherryPickApproved Used during the release process for point releases label Dec 5, 2019
@golang golang locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Security
Projects
None yet
Milestone
Go1.10.6
Development

No branches or pull requests
4 participants
@FiloSottile @dmitshur @gopherbot @pgaskin