-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: skip darwin-386-10_14
builder on release-branch.go1.12
#33756
Comments
I can take a look into this. |
@bcmills Do you think that we should build on >= 1.13, or only master? |
The underlying bug was fixed in 1.13, so this builder should run everything ≥ 1.13. |
Change https://golang.org/cl/191878 mentions this issue: |
I will re-deploy the coordinator and build.golang.org to pick up this change. |
@dmitshur, I notice that this builder is currently showing up in the build dashboard for |
@bcmills That is correct. I think it is a low priority enough wart that it can wait a few weeks (compared to the master branch of the main Go repo, I didn't think that could wait as long), but let me know if you think it's more disruptive and should be fixed sooner. |
release-branch.go1.12 has failures for darwin-386-10_14, which are fixed in Go 1.13. darwin-386 is not a first-class port and on a deprecated architecture for macOS, and can be skipped on older branches. Fixes golang/go#33756 Change-Id: I5f2e95fe9515978a85b986787d8126655f849629 Reviewed-on: https://go-review.googlesource.com/c/build/+/191878 Run-TryBot: Alexander Rakoczy <alex@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
As far as I can tell, the
darwin-386-10_14
builder was added for #31751 and has been failing forrelease-branch.go1.12
ever since.I doubt we'll want to fix a deprecated architecture on an old Go version, so we should skip the builder in that configuration instead.
CC @golang/osp-team
The text was updated successfully, but these errors were encountered: