syscall: (*LazyProc).Call does not keep arguments alive (anymore) [1.13 backport]

[gopherbot]

@zx2c4 requested issue #34474 to be considered for backport to the next 1.13 minor release.

@gopherbot please backport this, because mis-compilations are dangerous and the fix appears to be a trivial single line fix.

[mdempsky]

@FiloSottile I'm curious your thoughts here.

https://go-review.googlesource.com/c/go/+/198043 fixes direct calls to LazyProc.Call. It's minimal and safe and fixes the regression that was introduced in Go 1.8.

However, in #34684, I'm currently waiting for a decision on whether we support indirect call to LazyProc.Call too. If we do (which I don't think we handled correctly even back in Go 1.7), a somewhat more invasive fix will be necessary.

I'm somewhat inclined to proceed with CL 198043 as-is for now, and backport just that to Go 1.13. And then if we do decide to support indirect LazyProc.Call calls, it's okay to just fix that in Go 1.14 without backporting.

[ianlancetaylor]

I'm fairly certain that indirect calls to LazyProc.Call never worked correctly. Even if we fix that somehow, I don't see any reason to backport that fix to 1.13.

[gopherbot]

Change https://golang.org/cl/205244 mentions this issue: [release-branch.go1.13] cmd/compile: fix //go:uintptrescapes for basic method calls

[cagedmantis]

There is insufficient justification to backport this.