Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what does ## explicit mean? #37946

Closed
PhilipAbed opened this issue Mar 19, 2020 · 1 comment
Closed

what does ## explicit mean? #37946

PhilipAbed opened this issue Mar 19, 2020 · 1 comment

Comments

@PhilipAbed
Copy link

PhilipAbed commented Mar 19, 2020

What version of Go are you using (go version)?

$ go version 1.14

can anyone tell me what is the ## explicit for? i need to understand its effect on the modules.txt file

Does this issue reproduce with the latest release?

my project is breaking after trying to parse "modules.txt" file on go version 1.14 (works fine on go 1.13.5

What operating system and processor architecture are you using (go env)?

windows 10

go env Output
$ go env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\PhilipAbed\AppData\Local\go-build
set GOENV=C:\Users\PhilipAbed\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\PhilipAbed\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\PHILIP~1\AppData\Local\Temp\go-build988577882=/tmp/go-build -gno-record-gcc-switches

What did you do?

What did you expect to see?

a working parsing of the modules.txt

What did you see instead?

modules.txt broke since there's an extra "## explicit"

@bcmills
Copy link
Contributor

bcmills commented Mar 19, 2020

The vendor/modules.txt file format is not intended for other tools to consume.
(go list is the supported API for external tools to query dependency information: see https://golang.org/cmd/go/#hdr-List_packages_or_modules.)

The ## explicit entries were added for #33848.

@bcmills bcmills closed this as completed Mar 19, 2020
@golang golang locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants