Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: cannot go to definition when "ui.navigation.importShortcut": "Link" #45987

Closed
zyctree opened this issue May 6, 2021 · 1 comment
Closed

x/tools/gopls: cannot go to definition when "ui.navigation.importShortcut": "Link" #45987

zyctree opened this issue May 6, 2021 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.7.0

Comments

@zyctree
Copy link

zyctree commented May 6, 2021

What did you do?

add the following in vscode setting

    "gopls": {
        "ui.navigation.importShortcut": "Link"
    },

What did you expect to see?

"go to definition" doesn't work:in vscode, right-click on any function, or type, or variable, then click "go to definition" shows 'no definition found for XXX'.

logs shows

[Trace - 14:02:56.949 PM] Received response 'textDocument/definition - (103)' in 0ms.
Result: null

What did you see instead?

"go to definition" should work

it works when

    "gopls": {
        "ui.navigation.importShortcut": "Both"
    },

Build info

golang.org/x/tools/gopls v0.6.11
    golang.org/x/tools/gopls@v0.6.11-pre.1 h1:WC/eGK7AcuoBLCv3JzzQrRIaaeRTSRgVjwtbDlN18BI=
    github.com/BurntSushi/toml@v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
    github.com/google/go-cmp@v0.5.5 h1:Khx7svrCpmxxtHBq5j2mp/xVjsi8hQMfNLvJFAlrGgU=
    github.com/sergi/go-diff@v1.1.0 h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
    golang.org/x/mod@v0.4.2 h1:Gz96sIWK3OalVv/I/qNygP42zyoKp3xptRVCWRFEBvo=
    golang.org/x/sync@v0.0.0-20210220032951-036812b2e83c h1:5KslGYwFpkhGh+Q16bwMP3cOontH8FOep7tGV86Y7SQ=
    golang.org/x/sys@v0.0.0-20210403161142-5e06dd20ab57 h1:F5Gozwx4I1xtr/sr/8CFbb57iKi3297KFs0QDbGN60A=
    golang.org/x/tools@v0.1.1-0.20210504170620-03ebc2c9fca8 h1:rTLms91GhM16y4sUcNGLdel0jJ8jXdQeXuN+7evgYiQ=
    golang.org/x/xerrors@v0.0.0-20200804184101-5ec99f83aff1 h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
    honnef.co/go/tools@v0.1.3 h1:qTakTkI6ni6LFD5sBwwsdSO+AQqbSIxOauHTTQKZ/7o=
    mvdan.cc/gofumpt@v0.1.1 h1:bi/1aS/5W00E2ny5q65w9SnKpWEF/UIOqDYBILpo9rA=
    mvdan.cc/xurls/v2@v2.2.0 h1:NSZPykBXJFCetGZykLAxaL6SIpvbVy/UFEniIfHAa8A=
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 6, 2021
@gopherbot gopherbot added this to the Unreleased milestone May 6, 2021
@zyctree zyctree mentioned this issue May 10, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/318469 mentions this issue: internal/lsp: fix no definition when importShortcut is link

@golang golang locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.7.0
Development

Successfully merging a pull request may close this issue.

fix no definition when importShortcut is link zyctree/tools
4 participants
@hyangah @stamblerre @gopherbot @zyctree