Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/internal/quic/cmd/interop: unrecognized failures #63971

Closed
gopherbot opened this issue Nov 6, 2023 · 4 comments
Closed

x/net/internal/quic/cmd/interop: unrecognized failures #63971

gopherbot opened this issue Nov 6, 2023 · 4 comments
Assignees
@neild
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Nov 6, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/net/internal/quic/cmd/interop" && log ~ `panic: Log in goroutine`

Issue created automatically to collect these failures.

Example (log):

PASS
panic: Log in goroutine after TestTransfer has completed: server done

goroutine 21 [running]:
testing.(*common).logDepth(0xc000082ea0, {0xc0000140c5, 0xb}, 0x3)
	/tmp/workdir/go/src/testing/testing.go:1022 +0x674
testing.(*common).log(...)
	/tmp/workdir/go/src/testing/testing.go:1004
testing.(*common).Logf(0xc000082ea0, {0x89e735, 0x7}, {0xc0000bbd38, 0x1, 0x1})
	/tmp/workdir/go/src/testing/testing.go:1055 +0x9a
golang.org/x/net/internal/quic/cmd/interop.run.func1()
	/tmp/workdir/gopath/src/golang.org/x/net/internal/quic/cmd/interop/main_test.go:90 +0x38f
created by golang.org/x/net/internal/quic/cmd/interop.run in goroutine 19
	/tmp/workdir/gopath/src/golang.org/x/net/internal/quic/cmd/interop/main_test.go:74 +0x67a

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 6, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/internal/quic/cmd/interop" && test == ""
2023-11-06 20:51 freebsd-amd64-race net@39c9d013 go@434af853 x/net/internal/quic/cmd/interop (log) 
PASS
panic: Log in goroutine after TestTransfer has completed: server done

goroutine 21 [running]:
testing.(*common).logDepth(0xc000082ea0, {0xc0000140c5, 0xb}, 0x3)
	/tmp/workdir/go/src/testing/testing.go:1022 +0x674
testing.(*common).log(...)
	/tmp/workdir/go/src/testing/testing.go:1004
testing.(*common).Logf(0xc000082ea0, {0x89e735, 0x7}, {0xc0000bbd38, 0x1, 0x1})
	/tmp/workdir/go/src/testing/testing.go:1055 +0x9a
golang.org/x/net/internal/quic/cmd/interop.run.func1()
	/tmp/workdir/gopath/src/golang.org/x/net/internal/quic/cmd/interop/main_test.go:90 +0x38f
created by golang.org/x/net/internal/quic/cmd/interop.run in goroutine 19
	/tmp/workdir/gopath/src/golang.org/x/net/internal/quic/cmd/interop/main_test.go:74 +0x67a

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Nov 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Nov 6, 2023

(attn @neild)

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/539857 mentions this issue: internal/quic/cmd/interop: don't t.Log after test finishes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/internal/quic/cmd/interop" && log ~ `panic: Log in goroutine`
2023-11-06 21:52 freebsd-amd64-race net@26ea8175 go@9e933c18 x/net/internal/quic/cmd/interop (log) 
PASS
panic: Log in goroutine after TestTransfer has completed: server done

goroutine 21 [running]:
testing.(*common).logDepth(0xc000082ea0, {0xc000112055, 0xb}, 0x3)
	/tmp/workdir/go/src/testing/testing.go:1022 +0x674
testing.(*common).log(...)
	/tmp/workdir/go/src/testing/testing.go:1004
testing.(*common).Logf(0xc000082ea0, {0x89e735, 0x7}, {0xc0000bbd38, 0x1, 0x1})
	/tmp/workdir/go/src/testing/testing.go:1055 +0x9a
golang.org/x/net/internal/quic/cmd/interop.run.func1()
	/tmp/workdir/gopath/src/golang.org/x/net/internal/quic/cmd/interop/main_test.go:90 +0x38f
created by golang.org/x/net/internal/quic/cmd/interop.run in goroutine 19
	/tmp/workdir/gopath/src/golang.org/x/net/internal/quic/cmd/interop/main_test.go:74 +0x67a

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@neild @bcmills @gopherbot