Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/marker: 3 test cases failing on linux/arm #66686

Closed
dmitshur opened this issue Apr 4, 2024 · 3 comments
Closed

x/tools/gopls/internal/test/marker: 3 test cases failing on linux/arm #66686

dmitshur opened this issue Apr 4, 2024 · 3 comments
Assignees
@adonovan
Labels
arch-arm Issues solely affecting the 32-bit arm architecture. gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. OS-Linux Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 4, 2024

The definition/embed.txt, definition/misc.txt, and hover/sizeoffset.txt cases of Test are failing on linux/arm (32-bit) since they were introduced in CL 573076.

For example, see https://ci.chromium.org/b/8752115890806542801/test-results.

CC @adonovan.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 4, 2024
@dmitshur dmitshur added this to the Unreleased milestone Apr 4, 2024
@dmitshur dmitshur changed the title x/tools/gopls/internal/test/marker: x/tools/gopls/internal/test/marker: 3 test cases failing on linux/arm Apr 4, 2024
@dmitshur dmitshur added OS-Linux arch-arm Issues solely affecting the 32-bit arm architecture. labels Apr 4, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 4, 2024
@adonovan adonovan self-assigned this Apr 4, 2024
@adonovan
Copy link
Member

adonovan commented Apr 4, 2024

Sorry, another semantic merge conflict. Will fix presently.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 4, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/576657 mentions this issue: gopls/internal/test/marker/testdata: skip hover size tests on 32-bit arm

@adonovan
Copy link
Member

adonovan commented Apr 4, 2024

Sorry, another semantic merge conflict.

Actually not that: it's just that 32-bit arm is not on our regular CI radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
arch-arm Issues solely affecting the 32-bit arm architecture. gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. OS-Linux Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @adonovan @gopherbot