x/tools/gopls: gopls@latest does not build with go@tip

[findleyr]

With #67182, the SetCrashOutput API changed in 1.23. This breaks the build of gopls@v0.15.3, since it uses the old SetCrashOutput API. When go1.23rc1 is cut, we want users to be able to use it to build gopls. Therefore, we must cut a new gopls release such that gopls@latest builds.

Given the timeline, I think this must be a gopls@v0.15.4 with a cherry-picked fix. We had been on the fence about cutting a v0.15.4 anyway.

Putting this in the Go1.23 milestone so that it blocks the RC. We should aim for a new release next week at the latest.

CC @adonovan

[adonovan]

If cherrypicking the necessary pile of changes since Feb to make 15.4 support range-over-func seems fraught (and it does), one cheaper option would be to add a go1.23-tagged file to 15.4 that simply fails to compile with a more informative error that advises the user on what to do.

[findleyr]

We could do that. The v0.15.4 release branch also has a fix for a somewhat significant loopclosure analyzer bug (#66876). If the v0.15.4 release contains nothing other than a better instruction for 1.23, and a fix for loopclosure, that may be worth doing.

[findleyr]

Closing this in favor of https://go.dev/issue/67616, which targets gopls@v0.16.0. We decided to move forward with v0.16.0, rather than v0.15.4, in order to include all the other work to support Go 1.23 features.