Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/url: escaping parenthesis #9677

Closed
DAddYE opened this issue Jan 24, 2015 · 1 comment
Closed

net/url: escaping parenthesis #9677

DAddYE opened this issue Jan 24, 2015 · 1 comment

Comments

@DAddYE
Copy link

DAddYE commented Jan 24, 2015

Hi all!

I have a question, the package URL implements the RFC 3986 although if I read it correctly in section 2.2 it says about reserved chars:

      reserved    = gen-delims / sub-delims

      gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"

      sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
                  / "*" / "+" / "," / ";" / "="

However, checking the source of the current go implementation

I don't see the '(' and ')' part of reserved.

So this is causing some problems when I do http.Get() with urls that contains parens because they get escaped from http://example.com/fit-in/236x345/filters:quality(90):fill(ffffff) into http://example.com/fit-in/236x345/filters:quality%2890%29:fill%28ffffff%29 and the web server seems doesn't like it.

P.s. note that I'm not the author of these kind of urls nor able to upgrade the web-server to a recent version that probably could be able to unescape the path again.

@DAddYE DAddYE changed the title URL: escaping parens net/url: URL.String() escaping parenthesis Jan 24, 2015
@DAddYE DAddYE changed the title net/url: URL.String() escaping parenthesis net/url: escaping parenthesis Jan 24, 2015
@mikioh
Copy link
Contributor

mikioh commented Jan 24, 2015

Dup of #5684

@mikioh mikioh closed this as completed Jan 24, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants