New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: stream t.Log output as it happens #26270

Closed

zegl wants to merge 1 commit into golang:master from zegl:test-stream-log

Contributor

zegl commented Jul 8, 2018

Stream output of t.Log in tests via fmt.Printf if -test.v is set

Fixes #24929


          testing: stream t.Log output as it happens

e2a1dfc

Stream output of t.Log in tests via fmt.Printf if -test.v is set

Fixes golang#24929

googlebot added the cla: yes label

Contributor

gopherbot commented Jul 8, 2018

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

I would have expected a corresponding change to test2json. Is that really not necessary?

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2018

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=dd20f378

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2018

Message from Gobot Gobot:

Patch Set 1:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/dd20f378/linux-amd64_577bac0d.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 8, 2018

Message from Gobot Gobot:

Patch Set 1: TryBot-Result-1

10 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/dd20f378/linux-amd64_577bac0d.log
Failed on nacl-386: https://storage.googleapis.com/go-build-log/dd20f378/nacl-386_2717b8ad.log
Failed on freebsd-amd64-11_1: https://storage.googleapis.com/go-build-log/dd20f378/freebsd-amd64-11_1_8e8d9424.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/dd20f378/windows-386-2008_c6711748.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/dd20f378/linux-amd64-race_ebc9c9da.log
Failed on js-wasm: https://storage.googleapis.com/go-build-log/dd20f378/js-wasm_5fad2cec.log
Failed on openbsd-amd64-62: https://storage.googleapis.com/go-build-log/dd20f378/openbsd-amd64-62_cfe446ba.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/dd20f378/linux-386_6e5a99e4.log
Failed on nacl-amd64p32: https://storage.googleapis.com/go-build-log/dd20f378/nacl-amd64p32_652b91cd.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/dd20f378/windows-amd64-2016_d5f80f3f.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch 12 times, most recently from 4016de0 to d2f663c Compare

July 18, 2018 19:56

gopherbot force-pushed the master branch 9 times, most recently from 9092511 to 95c3348 Compare

July 19, 2018 18:17

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 26615:

Patch Set 1:

Friendly ping. Is this still active?

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 5065:

Patch Set 1:

Jean, it's in state "wait-release" per https://github.com/golang/go/wiki/Go-Release-Cycle

It'll reappear on people's radars (on our dashboards) once Go 1.11 is out.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jul 20, 2018

Message from Gerrit User 26615:

Patch Set 1:

Patch Set 1:

Jean, it's in state "wait-release" per https://github.com/golang/go/wiki/Go-Release-Cycle

It'll reappear on people's radars (on our dashboards) once Go 1.11 is out.

Apologies - should have been more clear. I was wondering whether the author still had this on their radar. If this is stale, I also have a PR. Don't want to step on toes if someone is actively working on the problem, though heh. :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

gopherbot force-pushed the master branch 4 times, most recently from 0090c13 to 8fbbf63 Compare

July 28, 2018 01:16

Contributor

gopherbot commented Nov 5, 2018

Message from Gerrit User 13550:

Patch Set 1:

How does this relate to the other CL fixing this bug, https://go-review.googlesource.com/c/go/+/127120/? Should this CL be abandoned?

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 5, 2018

Message from Gerrit User 14760:

Patch Set 1:

Patch Set 1:

How does this relate to the other CL fixing this bug, https://go-review.googlesource.com/c/go/+/127120/? Should this CL be abandoned?

We can abandon this one. The other one seems to have more traction.

Please don’t reply on this GitHub thread. Visit golang.org/cl/122581.
After addressing review feedback, remember to publish your drafts!

zegl closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels