-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strings: adding micro-optimization for TrimSpace #46862
base: master
Are you sure you want to change the base?
Conversation
strings.TrimSpace string's end final trimming should use more specific TrimRightFunc instead of common TrimFunc (because start has already trimmed before)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: 040607a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/329731 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/329731. |
Message from Robert Griesemer: Patch Set 1: Code-Review-2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329731. |
Message from Robert Griesemer: Patch Set 1: Code-Review-2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/329731. |
replace for string's end trimming TrimFunc -> TrimRightFunc strings.TrimSpace string's end trimming should use more specific TrimRightFunc instead of common TrimFunc (because start has already trimmed before) Change-Id: I827f1a25c141e61edfe1f8b11f6e8cd685f8b384 GitHub-Last-Rev: 040607a GitHub-Pull-Request: #46862 Reviewed-on: https://go-review.googlesource.com/c/go/+/329731 Auto-Submit: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Russ Cox <rsc@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
replace for string's end trimming TrimFunc -> TrimRightFunc
strings.TrimSpace string's end trimming should use more specific TrimRightFunc instead of common TrimFunc (because start has already trimmed before)