You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 9, 2021. It is now read-only.
I've always been curious why the following triggers a linting error
package main
typefoostruct{}
funcmain() {
}
// exported func Bar returns unexported type foo.foo, which can be annoying to usefuncBar() foo {
returnfoo{}
}
I've used this approach in a couple projects now, but because golint throws an error it does give me some pause. Is this frowned upon in Go?
My justification would be that I do not want users of my package to be able to create their own foo and must get their foo from Bar, because otherwise the type would be useless to them and wouldn't be used in a way that makes sense.
The text was updated successfully, but these errors were encountered:
Thank you for submitting this issue! As per golang/go#38968, we are freezing and deprecating golint. There's no drop-in replacement to golint per se, but you should find that Staticcheck works well in encouraging good Go code, much like golint did in the past, since it also includes style checks. There's always gofmt and go vet too, of course.
If you would like to contribute further, I'd encourage you to engage Staticcheck's issue tracker or look at vet's open issues, as they are both actively maintained. If you have an idea that doesn't fit into either of those tools, you could look at other Go linters, or write your own - these days it's fairly straightforward with go/analysis.
To help avoid confusion, I'm closing all issues before we freeze the repository. If you have any feedback, you can leave a comment on the proposal thread where it was decided to deprecate golint - though note that the proposal has been accepted for nearly a year. Thanks!
I've always been curious why the following triggers a linting error
I've used this approach in a couple projects now, but because golint throws an error it does give me some pause. Is this frowned upon in Go?
My justification would be that I do not want users of my package to be able to create their own
foo
and must get theirfoo
fromBar
, because otherwise the type would be useless to them and wouldn't be used in a way that makes sense.The text was updated successfully, but these errors were encountered: