Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

Reopen issue #89 #491

Closed
jossef opened this issue May 4, 2020 · 8 comments
Closed

Reopen issue #89 #491

jossef opened this issue May 4, 2020 · 8 comments

Comments

@jossef
Copy link

jossef commented May 4, 2020

Reopen issue #89
You shouldn't ignore your users' feedback.

image

@noonien
Copy link

noonien commented May 4, 2020

I strongly suggest you ask for a refund!

@mdlayher
Copy link
Member

mdlayher commented May 4, 2020

Please don't spam mentions in the future.

@ianlancetaylor
Copy link

Thanks, but, quoting the original response:

When code can't follow the usual style conventions there's nothing to do. Just ignore what golint says. Its output is meant for humans anyway.

The lint program implements a certain set of style guidelines, that are now documented at https://golang.org/wiki/CodeReviewComments. If you want to follow a different set of style guidelines, modify or rewrite golint.

The golint program is not intended to be all things to all people.

@as
Copy link

as commented May 5, 2020

I too can send a link to 31 people but that isn't a representative sample of users' opinions, nor is it a meritable argument on its own to take any action.

Ignoring something and acknowledging it but not doing anything are different things. They should not be equivocated.

@wagslane
Copy link

wagslane commented May 5, 2020

God please don't make golint like eslint. Keep the rules consistent. Down with configurability.

@jossef
Copy link
Author

jossef commented May 5, 2020

You can keep telling yourself that. It's not what most users want judging by the vote count on #263, #186, ...

image

@cflewis
Copy link
Member

cflewis commented May 5, 2020

golangci-lint allows you to exclude certain messages, and supports golint. The license is GPL 2 which is fine for your personal use. I suggest you consider switching your tool chain to use that instead.

As @ianlancetaylor said, it is not possible to make tools that are all things to all people, and those that attempt it invariably end up too complex. I don’t want to put words in anyone’s mouth, but reducing complexity in the tooling has generally worked well for the Go project and I wouldn’t expect that to change.

I think you will be happier in the long run if you try to respect that the this issue is closed, and move on to golangci-lint which is a solution that is available to you immediately.

@chavacava
Copy link

revive is a drop-in replacement for golint that allows disabling certain messages by configuration and is extensible (it supports +50 checking rules)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants