Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Separate Readme sections for Source mode, Reflect mode and Flags #495

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

dstivanov
Copy link
Contributor

Description

As a newbie in the tooling I was not able to find out that there are two modes of generation (Source and Reflect) from first glance. I believe that this small change can help the other like me.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests - N/A

Reviewer Notes

  • The code flow looks good.
  • Tests added.

Release Notes

N/A - no release changes, only markdown changes

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dstivanov
Copy link
Contributor Author

@googlebot I signed it

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 23, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@codyoss
Copy link
Member

codyoss commented Oct 23, 2020

Thanks for the PR, just a couple small nits.

dstivanov and others added 2 commits October 26, 2020 08:51
Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
Co-authored-by: Cody Oss <6331106+codyoss@users.noreply.github.com>
@dstivanov dstivanov requested a review from codyoss October 26, 2020 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants