This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Support for variadic arguments in SetArgs method #703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README
Add Uber maintainers.
This rewrites the import path from "github.com/golang/mock" to "go.uber.org/mock".
Ran go mod tidy and removed a bunch of unused dependencies from go.sum. Ideally we should run this as part of some lint check step as we do in other uber-go repositories.
Update README to reflect: - current status - installation path - supported Go versions - Remove irrelevant info
from Go 1.19, `go fmt` reformats doc comments. https://go.dev/doc/go1.19#go-doc > Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, [gofmt](https://go.dev/cmd/gofmt) now reformats doc comments to make their rendered meaning clearer. See “[Go Doc Comments](https://go.dev/doc/comment)” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package [go/doc/comment](https://go.dev/pkg/go/doc/comment/) provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text.
Go 1.18 is no longer supported. Now, we can bump Go version to 1.19.
- Bump checkout/setup-go actions versions - Drop pre-1.18 action - Edit action permissions to readonly
This preps v0.1.0 release. Added a CHANGELOG file to keep track of release changes according to semver. Ref #17.
This minimal PR documents the installation command. It took me a moment to look it up from the github.com/golang repo. Hopefully this can help save a few moments for others. --------- Co-authored-by: Sung Yoon Whang <sungyoonwhang@gmail.com>
Go reference uses module name rather than repository URL as a package name.
This is an initial implementation of the proposal outlined in this issue, #685
Now that we've released an initial version, update the README to reflect that.
Upgrade go.mod
Hi, Small change after the migration from golang to uber, so the users don't end up running the wrong tests. Signed-off-by: Adrien Barreau <adrien.barreau@live.fr>
This PR replaces the deprecated package `io/ioutil` with `io` and `os`.
From [actions/setup-go@v4.0.0](https://github.com/actions/setup-go/releases/tag/v4.0.0), the action caches the dependencies by default. We don't need to use actions/cache any more. In addition, caching the dependencies requires `go.sum`. actions/checkout should precede actions/setup-go.
This PR replaces `interface{}` with `any` by running the command:
```sh
gofmt -w -r 'interface{} -> any' .
```
This PR changes URLs in the docs: - replace `https://github.com/uber/mock` to `https://github.com/uber-go/mock`; - replace `https://golang.org/` to `https://go.dev/`; - update README with a link to CONTRIBUTIONS.md; - fix grammar issues.
fixes [#646](#646), Hi, my friends. Merging this pull request can fix old bugs related to defining the local names of imported packages by using the -imports flag. I have also added a test for that, and it works properly. If you have any ideas or concerns regarding the PR, feel free to tell me. --------- Co-authored-by: Erfan Momeni <Erfan.Momeni@snapp.cab> Co-authored-by: n0trace <n0trace@protonmail.com> Co-authored-by: utagawa kiki <utagawakiki@gmail.com> Co-authored-by: Sung Yoon Whang <sungyoonwhang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing the one of the older issue in the repository:
#174 Support variadic pointer parameter on caller.SetArg
Much appreciate to @bergotorino for his PR as an inspiration!
Taking into account previous feedback, I added tests for this case