From d684c6f886692f8b63049d3dabe4f1911ae979c3 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 10 Nov 2022 18:59:02 +0000 Subject: [PATCH] execabs: isGo119ErrDot: use errors.Is instead of string-matching Addresses the TODO added in CL 403256. Change-Id: Iae44242e00b6a309cc0f1e336462bc2d4995a5e2 GitHub-Last-Rev: 1adfdb799489c068127e5088cd131dcca79d86df GitHub-Pull-Request: golang/sys#142 Reviewed-on: https://go-review.googlesource.com/c/sys/+/448877 Auto-Submit: Ian Lance Taylor Run-TryBot: Ian Lance Taylor Reviewed-by: Michael Knyszek Run-TryBot: Ian Lance Taylor TryBot-Result: Gopher Robot Reviewed-by: Ian Lance Taylor --- execabs/execabs_go119.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/execabs/execabs_go119.go b/execabs/execabs_go119.go index 1e7a9ada0..46c5b525e 100644 --- a/execabs/execabs_go119.go +++ b/execabs/execabs_go119.go @@ -7,9 +7,11 @@ package execabs -import "strings" +import ( + "errors" + "os/exec" +) func isGo119ErrDot(err error) bool { - // TODO: return errors.Is(err, exec.ErrDot) - return strings.Contains(err.Error(), "current directory") + return errors.Is(err, exec.ErrDot) }