Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/gopls: add command line support for links #181

Closed
wants to merge 4 commits into from

Conversation

kalmanb
Copy link
Contributor

@kalmanb kalmanb commented Oct 24, 2019

This adds support for calling links from the gopls command line,
e.g.

$ gopls links ~/tmp/foo/main.go

Optional arguments are:
-json, which emits range and uri in JSON
With no arguments, a unique list of links are emitted.

Updates golang/go#32875

@gopherbot
Copy link
Contributor

This PR (HEAD: 4f9e3b6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/203297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 1:

(5 comments)

Thank you for contributing this change! A few small comments.


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

@kalmanb kalmanb changed the title tools/gopls: add command line support for imports tools/gopls: add command line support for links Oct 29, 2019
@gopherbot
Copy link
Contributor

This PR (HEAD: 736b606) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/203297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kalman Bekesi:

Patch Set 3:

(6 comments)

Updated, thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

e.g.

$ gopls links ~/tmp/foo/main.go

Optional arguments are:
-json, which emits range and uri in JSON
With no arguments, a unique list of links are emitted.

Updates golang/go#32875
@gopherbot
Copy link
Contributor

This PR (HEAD: 48eb095) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/203297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kalman Bekesi:

Patch Set 4:

(1 comment)

Patch Set 3:

(1 comment)

I've refactored the tests and rebased.


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 4:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 7ed1e46) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/203297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Kalman Bekesi:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 6: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=8732f011


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 1, 2019
This adds support for calling links from the gopls command line,
e.g.

$ gopls links ~/tmp/foo/main.go

Optional arguments are:
-json, which emits range and uri in JSON
With no arguments, a unique list of links are emitted.

Updates golang/go#32875

Change-Id: I1e7cbf00a636c05ccf21bd544d9a5b7742d5d70b
GitHub-Last-Rev: 7ed1e46
GitHub-Pull-Request: #181
Reviewed-on: https://go-review.googlesource.com/c/tools/+/203297
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 6: TryBot-Result+1

TryBots are happy.


Please don’t reply on this GitHub thread. Visit golang.org/cl/203297.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/203297 has been merged.

@gopherbot gopherbot closed this Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants