codelens: ldflags do not make effects in run test #1831
Labels
debug/config
Issues for config discrepancies b/n settings.json, launch.json, launch with F5, run test, debug test
Debug
Issues related to the debugging functionality of the extension.
Milestone
Comments
|
Can you please add these flags to the |
stamblerre
added
the
WaitingForInfo
|
It makes no difference. |
|
@Troublor What about the following? (no But it's likely this setting - part of it was discussed in go-delve/delve#2718 (comment) :-( |
|
Hmm, after I remove the I am using However, if I click the |
stamblerre
added
Debug
|
I believe this problem is because vscode-go constructs arguments for the As documented at https://pkg.go.dev/cmd/go#hdr-Testing_flags, To my understanding, when Perhaps the simplest fix is to specify the package as the first argument to the Line 460 in 08dacee while the packages are appended afterwards at Line 475 in 08dacee so would it be possible to try and reverse the ordering? |
polinasok
changed the title
polinasok
added
the
debug/config
hyangah
added a commit
to hyangah/delve
that referenced
this issue
Sep 7, 2023
This change accepts both string type and []string (actually,
[]interface{} type due to Go's json decoding behavior.
Fixes go-delve#2718
For golang/vscode-go#1831, golang/vscode-go#1027
hyangah
added a commit
to hyangah/delve
that referenced
this issue
Sep 8, 2023
This change accepts both string type and []string. dap.BuildFlags is a union of string and []string. Fixes go-delve#2718 For golang/vscode-go#1831, golang/vscode-go#1027
hyangah
added a commit
to hyangah/delve
that referenced
this issue
Sep 13, 2023
This change accepts both string type and []string. dap.BuildFlags is a union of string and []string. Fixes go-delve#2718 For golang/vscode-go#1831, golang/vscode-go#1027
hyangah
added a commit
to hyangah/delve
that referenced
this issue
Sep 15, 2023
This change accepts both string type and []string. dap.BuildFlags is a union of string and []string. Fixes go-delve#2718 For golang/vscode-go#1831, golang/vscode-go#1027
hyangah
added a commit
to hyangah/delve
that referenced
this issue
Sep 15, 2023
This change accepts both string type and []string. dap.BuildFlags is a union of string and []string. Fixes go-delve#2718 For golang/vscode-go#1831, golang/vscode-go#1027
derekparker
pushed a commit
to go-delve/delve
that referenced
this issue
Sep 19, 2023
This change accepts both string type and []string. dap.BuildFlags is a union of string and []string. Fixes #2718 For golang/vscode-go#1831, golang/vscode-go#1027
|
Is there any update on this? This breaks running individual tests in the testify suite. Is there any workaround? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Go, VS Code & VS Code Go extension are you using?
Version Information
go versionto get version of Go from the VS Code integrated terminal.go version go1.17.2 linux/amd64gopls -v versionto get version of Gopls from the VS Code integrated terminal.code -vorcode-insiders -vto get version of VS Code or VS Code Insiders.v0.28.1Go: Locate Configured Go Toolscommand.Share the Go related settings you have added/edited
Run
Preferences: Open Settings (JSON)command to open your settings.json file.Share all the settings with the
go.or["go"]orgoplsprefixes.{ "go.buildFlags": [ "-ldflags='-extldflags=-Wl,--allow-multiple-definition'" ] }Describe the bug
A clear and concise description of what the bug.
The
ldflags:-extldflags=-Wl,--allow-multiple-definition'does not take effect when I run tests by clicking therun testbutton in the editor beside the test definition.Compilation errors complain the multiple definitions of C functions.
The multiple definitions of
secp256k1*functions are expected since I used two packages, one of which is a fork of the other, and they contains some identical C code.Outputs are as follows:
Multiple definitioncompilation errors should not be thrown.When I copy & paste the command
/home/troublor/.gvm/gos/go1.17.2/bin/go test -timeout 30s -run ^TestVersion$ github.com/Troublor/erebus/packages/erebus-hunter -ldflags='-X=main.version=1.0' -ldflags='-extldflags=-Wl,--allow-multiple-definition'in the viscode integrated terminal, it executes with no error and the test passes.Interestingly,
debug testfunctionality works well.Steps to reproduce the behavior:
As described in the previous section.
Screenshots or recordings
If applicable, add screenshots or recordings to help explain your problem.
The text was updated successfully, but these errors were encountered: