-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gorename command not printed at any logging level #2634
Comments
"go.logging.level" was added to debug much later as a hack to debug issues related to finding 'go' binary. :-( Can you tell us more about why you couldn't use gopls? |
Fixes golang#2634, or at least it might. I don't know how to build this project, don't know typescript, etc.
@hyangah Hello and thank you for your response. Indeed, my project builds Go as a dependency because we're cross-compiling for a few different archs (we'll be running Go on tiny MIPS board!), we have a few hacks to Go as well as a couple of patches that we need to send upstream (MIPS-specific optimizations). Anyway,
Finally, I've avoided having to learn what gopls is and now I'm being forced to. When I read "language server", my brain thinks "ok, so m$ or somebody wants me to use some service in the cloud and collect metrics or data from my work. That's great, another friendly 'let me help you' while they siphon my data." But I'm being a good programmer and reading up. It sounds freaking awesome!! (Off-topic warning) I really hope there's support (or will be) for modeling via UML. It sounds like a powerful mechanism, even if m$ wrote it! I'm familiar with intermediate code representation as I've worked on gcc, adding optimizations to it. There's a lot that can be done with such IR. |
@hyangah ping |
Hi Daniel, I do encourage you to try using the rename feature built in to gopls. The old gorename tool has been unmaintained for a long time and has many bugs, whereas the LSP-integrated feature is actively maintained. We do try to minimize disruption as code evolves, and the old gorename tool has been documented as a "legacy mode" for some time now; see https://github.com/golang/vscode-go/wiki/tools#misc-tools-used-in-the-legacy-mode Also, be assured that we take the privacy of your source code very seriously, and do not collect any source code or any information derived from it. |
In the next vscode go (v0.40.0), we are removing all legacy language providers (we announced in #2799 and notified affected users in v0.39.0 released in June. One of the legacy language feature providers is gorename. So, this issue is obsolete. @daniel-santos Gopls can handle code that is targeted to be cross-compiled (e.g. set GOOS/GOARCH and necessary env vars in the [ |
When attempting to rename an identifier via
F2
or right click --> Rename Symbol, I am am getting the very simple error:However, this bug report is about the fact that I have logging set to verbose and am not seeing the command run:
Note: other settings omitted.
The correct behavior is to output the command run at an appropriate debug logging level (decided by the maintainer), but always when set to verbose.
The text was updated successfully, but these errors were encountered: