Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/git/git: CVE-2020-5260 #2304

Closed
tatianab opened this issue Nov 8, 2023 · 1 comment
Closed
Labels
excluded: LEGACY_FALSE_POSITIVE (DO NOT USE) Vulnerability marked as false positive before we introduced the triage process

Comments

@tatianab
Copy link
Contributor

tatianab commented Nov 8, 2023

CVE-2020-5260 references github.com/git/git, which may be a Go module.

Description:
Affected versions of Git have a vulnerability whereby Git can be tricked into sending private credentials to a host controlled by an attacker. Git uses external "credential helper" programs to store and retrieve passwords or other credentials from secure storage provided by the operating system. Specially-crafted URLs that contain an encoded newline can inject unintended values into the credential helper protocol stream, causing the credential helper to retrieve the password for one server (e.g., good.example.com) for an HTTP request being made to another server (e.g., evil.example.com), resulting in credentials for the former being sent to the latter. There are no restrictions on the relationship between the two, meaning that an attacker can craft a URL that will present stored credentials for any host to a host of their choosing. The vulnerability can be triggered by feeding a malicious URL to git clone. However, the affected URLs look rather suspicious; the likely vector would be through systems which automatically clone URLs not visible to the user, such as Git submodules, or package systems built around Git. The problem has been patched in the versions published on April 14th, 2020, going back to v2.17.x. Anyone wishing to backport the change further can do so by applying commit 9a6bbee (the full release includes extra checks for git fsck, but that commit is sufficient to protect clients against the vulnerability). The patched versions are: 2.17.4, 2.18.3, 2.19.4, 2.20.3, 2.21.2, 2.22.3, 2.23.2, 2.24.2, 2.25.3, 2.26.1.

References:

Cross references:

See doc/triage.md for instructions on how to triage this report.

modules:
    - module: github.com/git/git
      vulnerable_at: 2.42.1+incompatible
      packages:
        - package: git
cves:
    - CVE-2020-5260
references:
    - advisory: https://github.com/git/git/security/advisories/GHSA-qm7j-c969-7j4q
    - fix: https://github.com/git/git/commit/9a6bbee8006c24b46a85d29e7b38cfa79e9ab21b
    - web: https://lore.kernel.org/git/xmqqy2qy7xn8.fsf@gitster.c.googlers.com/
    - web: https://www.debian.org/security/2020/dsa-4657
    - web: https://lists.debian.org/debian-lts-announce/2020/04/msg00010.html
    - web: http://www.openwall.com/lists/oss-security/2020/04/15/5
    - web: http://packetstormsecurity.com/files/157250/Git-Credential-Helper-Protocol-Newline-Injection.html
    - web: http://www.openwall.com/lists/oss-security/2020/04/15/6
    - web: http://lists.opensuse.org/opensuse-security-announce/2020-04/msg00027.html
    - web: https://support.apple.com/kb/HT211141
    - web: https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/XPCEOIFLLEF24L6GLVJVFZX4CREDEHDF/
    - web: http://www.openwall.com/lists/oss-security/2020/04/20/1
    - web: https://security.gentoo.org/glsa/202004-13
    - web: https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/7TVS5UG6JD3MYIGSBKMIOS6AF7CR5IPI/
    - web: https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/PN3FUOXKX3AXTULYV53ACABER2W2FSOU/
    - web: https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/MOCTR2SEHCPSCOVUQJAGFPGKFMI2VE6V/
    - web: https://usn.ubuntu.com/4329-1/
    - web: https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/message/74Q7WVJ6FKLIN62VS2JD2XCNWK5TNKOW/
    - web: http://lists.opensuse.org/opensuse-security-announce/2020-05/msg00003.html

@tatianab tatianab added the excluded: LEGACY_FALSE_POSITIVE (DO NOT USE) Vulnerability marked as false positive before we introduced the triage process label Nov 8, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/540721 mentions this issue: data/excluded: batch add 135 excluded reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded: LEGACY_FALSE_POSITIVE (DO NOT USE) Vulnerability marked as false positive before we introduced the triage process
Projects
None yet
Development

No branches or pull requests

2 participants