Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: suggestion regarding GO-2023-2331 #2949

Closed
bcho opened this issue Jun 25, 2024 · 3 comments
Closed

x/vulndb: suggestion regarding GO-2023-2331 #2949

bcho opened this issue Jun 25, 2024 · 3 comments

Comments

@bcho
Copy link

bcho commented Jun 25, 2024

Report ID

GO-2023-2331

Suggestion/Comment

Currently the GO-2023-2331 / CVE-2023-47108 is being excluded from the vuln db result as it was marked as "DEPENDENT_VULNERABILITY" mentioned in here: #2331 (comment)

I understand the CVE-2023-47108 is sharing the same root cause as CVE-2023-25151 , however, the affected code paths from these two CVEs are different:

If we exclude the CVE-2023-47108, it will result in false negative from govulncheck result since the affected dep and code path is being scanned.

I have a reproduction in here: https://github.com/bahe-msft/govuln-CVE-2023-47108/blob/8977c03e4fb1347cfe46d651481db066d0816e51/main.go#L10-L12 , which we invoked the affected code in the demo program. This demo code will not be flagged with this CVE (govuln result) while it's being flagged by trivy.

If the two CVEs are affecting different code paths, should we keep both as active? This is very helpful if we want to make use of the VEX feature from govulncheck since we will need to inspect the binary with the CVE details instead of excluding it.

@ritazh
Copy link

ritazh commented Jun 26, 2024

xref components that need this: kubernetes/apiserver#106 (comment)

@timothy-king timothy-king self-assigned this Jun 26, 2024
@timothy-king
Copy link
Contributor

Thank you for the report. We will look into this.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595257 mentions this issue: data/reports: unexclude GO-2023-2331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants