Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/coreos/ignition: GHSA-hj57-j5cw-2mwp #468

Closed
GoVulnBot opened this issue May 25, 2022 · 2 comments

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-hj57-j5cw-2mwp, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
github.com/coreos/ignition 2.14.0 < 2.14.0

See doc/triage.md for instructions on how to triage this report.

package: github.com/coreos/ignition
versions:
  - introduced: v0.0.0
    fixed: v2.14.0
description: |-
    ### Impact
    Unprivileged software in VMware VMs, including software running in unprivileged containers, can retrieve an Ignition config stored in a hypervisor guestinfo variable or OVF environment.  If the Ignition config contains secrets, this can result in the compromise of sensitive information.

    ### Patches
    Ignition 2.14.0 and later [adds](https://github.com/coreos/ignition/pull/1350) a new systemd service, `ignition-delete-config.service`, that deletes the Ignition config from supported hypervisors (currently VMware and VirtualBox) during the first boot.  This ensures that unprivileged software cannot retrieve the Ignition config from the hypervisor.

    If you have external tooling that requires the Ignition config to remain accessible in VM metadata after provisioning, and your Ignition config does not include sensitive information, you can prevent Ignition 2.14.0 and later from deleting the config by masking `ignition-delete-config.service`.  For example:

    ```json
    {
      "ignition": {
        "version": "3.0.0"
      },
      "systemd": {
        "units": [
          {
            "name": "ignition-delete-config.service",
            "mask": true
          }
        ]
      }
    }
    ```

    ### Workarounds
    [Avoid storing secrets](https://coreos.github.io/ignition/operator-notes/#secrets) in Ignition configs. In addition to VMware, many cloud platforms allow unprivileged software in a VM to retrieve the Ignition config from a networked cloud metadata service. While platform-specific mitigation is possible, such as firewall rules that prevent access to the metadata service, it's best to store secrets in a dedicated platform such as [Hashicorp Vault](https://www.vaultproject.io/).

    ### Advice to Linux distributions
    Linux distributions that ship Ignition should ensure the new `ignition-delete-config.service` is installed and enabled by default.

    In addition, we recommend shipping a service similar to `ignition-delete-config.service` that runs when existing machines are upgraded, similar to the one in https://github.com/coreos/fedora-coreos-config/pull/1738. Consider giving your users advance notice of this change, and providing instructions for masking `ignition-delete-config.service` on existing nodes if users have tooling that requires the Ignition config to remain accessible in VM metadata.

    ### References
    For more information, see #1300 and #1350.

    ### For more information
    If you have any questions or comments about this advisory, [open an issue in Ignition](https://github.com/coreos/ignition/issues/new/choose) or email the CoreOS [development mailing list](https://lists.fedoraproject.org/archives/list/coreos@lists.fedoraproject.org/).
published: 2022-05-25T19:37:37Z
last_modified: 2022-05-25T19:37:39Z
ghsas:
  - GHSA-hj57-j5cw-2mwp

@neild
Copy link
Contributor

neild commented Jun 14, 2022

Vulnerability in tool.

@neild neild closed this as completed Jun 14, 2022
@julieqiu
Copy link
Member

julieqiu commented Aug 1, 2022

Duplicate of #451.

@neild neild added duplicate and removed NotGoVuln labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants