-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom plugins #690
Comments
Feels like a duplicate of #631 |
I think an idea can be to build golangci-lint (through The with:
foo: bar Then maybe the extra configuration can be provided via a dedicated file, something like that: plugins:
- path: /path/to/plugin/sources/
destination: ./example/foo.so
- path: /path/to/another/plugin/sources/
destination: ./example/bar.so related to golangci/golangci-lint#2566 FYI #540 is not closed. |
The PR #768 is now merged and I created a new release of the action. I also created an example to explain how to use custom linters (plugins) with this GitHub Action: https://github.com/golangci/golangci-lint-action-plugin-example I didn't do the extra configuration support because I think it's not needed for now but we can change our mind on that in the future. |
Welcome
Your feature request related to a problem? Please describe.
I'd like to be able to use custom golangci-lint plugins with the GitHub action. I can almost achieve this with the following steps:
container: my-golangci-container
Since plugins need to be built from the same
go.mod
that the tool itself is built from, I need a way to point the action to my binary.Describe the solution you'd like.
#676 Is achieving something similar, but for this use-case it can be even simpler: if I can specify the path to
golangci-lint
on the running container and tell the action to skip downloading the asset (and just use the one I'm pointing to instead), everything would work well.Describe alternatives you've considered.
I can currently run
golangci-lint
as a separate action on my own container, but then I miss out on getting comments on my PR, caching, etc.Additional context.
No response
The text was updated successfully, but these errors were encountered: