Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13 not semvert #371

Closed
eaglemoor opened this issue Jan 23, 2019 · 4 comments
Closed

v1.13 not semvert #371

eaglemoor opened this issue Jan 23, 2019 · 4 comments

Comments

@eaglemoor
Copy link

eaglemoor commented Jan 23, 2019

v1.13 is not semvert. We can't use v1.13 in go get...

Please, add semvert tag like v1.13.0

https://semver.org

@lopezator
Copy link
Member

lopezator commented Jan 24, 2019

Here's the discussion about allowing tags like v1.13 which implicitly mean the same as v1.13.0, but we aren't there yet, and maybe we'll never be.

semver/semver#237

Aditionally I have open this issue on golang repo, because modules currently fail finding a version if you are not using an strict semver tag like v1.13.0.

golang/go#29731

Looks like there are considering fixing this, falling back from versions like v1.13 to v1.13.0 but were aren't there yet also.

Maybe we should consider a new (non-changing) patch release v1.13.1 ? Actual tag is not usable from modules directly.

@eaglemoor Temporal fix would be to pin to the latest commit on the v1.13 tag:

go get github.com/golangci/golangci-lint@2192097e7f56c84fa793b6f933056cd18773fae2

CC\ @jirfag

@eaglemoor
Copy link
Author

I think we can close this issue. U have v1.13.1 👍

@lopezator
Copy link
Member

lopezator commented Jan 24, 2019

You can close it by yourself if you consider it fixed @eaglemoor

@jirfag
Copy link
Member

jirfag commented Jan 24, 2019

thank you,
I will try to make a next minor release as 1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants