Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance List of Generic Bullet points #315

Closed
TheHollidayInn opened this issue Jan 5, 2019 · 6 comments
Closed

Performance List of Generic Bullet points #315

TheHollidayInn opened this issue Jan 5, 2019 · 6 comments

Comments

@TheHollidayInn
Copy link
Contributor

Continuing from: #288 (comment). As suggested, let's discuss a list of bullet points to be added to our generic list.

Looking at this: #302, here are a few that seemed to be good:

  • Use text compression
  • Deal with database and external APIs in batches
  • Benchmark slow db calls
  • Analyze repeated API Calls/Database Queries to cache them
  • Serve static assets from a CDN

Are these good? and what else should we add?

Also, the format will be similar to this: https://github.com/i0natan/nodebestpractices#-65-collection-of-generic-security-best-practices

@goldbergyoni
Copy link
Owner

@TheHollidayInn Perfect 🎖

Just try adding some more info & links to each (when the implementation tools are highly popular and standard), for example:
"Benchmark slow db calls" - share link to Postgres & mySQL query plans and slow queries profiling

Let's start refining this using a PR?

@goldbergyoni
Copy link
Owner

@TheHollidayInn Didn't you have another performance PR? I suddenly can't find it...

@TheHollidayInn
Copy link
Contributor Author

Will do! I'll open a PR and add more.

Here is the other part I was working on: #294 (comment). I posted the initial thoughts in the issue per your request. I can switch it to a PR if you'd like!

@goldbergyoni
Copy link
Owner

@TheHollidayInn Great, so I'm following on #320 & #294

@stale
Copy link

stale bot commented Apr 14, 2019

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Apr 14, 2019
@goldbergyoni
Copy link
Owner

Closing as we're engaged on the PR #320

@stale stale bot removed the stale label Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants