Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basque translation #842

Closed
anediaz opened this issue Jan 8, 2021 · 7 comments
Closed

Basque translation #842

anediaz opened this issue Jan 8, 2021 · 7 comments

Comments

@anediaz
Copy link
Contributor

anediaz commented Jan 8, 2021

I can help with Basque translation, the Basque is my mother tongue.
I created this issue a long time ago but I didn't have the time to do it, so the issue was closed (which I find logical).
Now I have more time and I have almost finished the entire translation.

Thanks in advance

@goldbergyoni
Copy link
Owner

@anediaz Welcome back, I remember our conversation well (I still plan to visit the area once Covid leave:)) and happy to see you back. We have a bot that closes issues automatically based on activity. Having Basque translation would be super-awesome, looking forward 🌈

@anediaz
Copy link
Contributor Author

anediaz commented Jan 9, 2021

I'll do it certainly this week end.
Could you please remind me the way to contribute ?
I am supposed to fork the repository and after having finished, create a PR, is that right?

@anediaz
Copy link
Contributor Author

anediaz commented Jan 14, 2021

Hello everybody,
I've finished the Readme's Basque translation, I'm working on "See more" pages of each section.
I'd like to know if you prefer merging a translation on the very end or you accept publishing partially-translated versions, and in this case I would create a PR.

Thank you in advance,
Ane

@goldbergyoni
Copy link
Owner

Hey @anediaz , It sounds fantastic 💜. If the entire home page is translated, we can merge it and just put the Basque flag in the 'Translation in progress' paranthesis. Make sure to also add your name and the flag. I'll take care to put in news + Tweet + add you to contributors.

@anediaz
Copy link
Contributor Author

anediaz commented Jan 17, 2021

Hello,
This is great news! I'll probably create a PR at the end of the day.
The Basque flag is already added in my branch, as well as the "Basque translation in progress" mention at the beginning of each the READMEs, except the Korean and Chinese versions I think (I have to check it out).

I guess I am supposed to add my name at the end of the README, in the "Translations in progress" section. I'd like to include my father's name too, if you don't mind, as he has contributed very actively in the translation.

Should I add my name into "Contributors" part too, or I am mixing "translators" and "contributors"?

@kevynb
Copy link
Collaborator

kevynb commented Jan 17, 2021

Yes you can add a line in "Translations in progress" !
I don't see a reason to oppose adding the name of your father since he participated in the translation 😃
We have a bot that automatically adds people to the "Contributors" section for their work. As soon as your PR gets merged, we will ask it to add you there

@anediaz
Copy link
Contributor Author

anediaz commented Apr 23, 2021

I think we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants