From 3c0dfa1bd9ac804bfffc701784e8f5c1ce1675de Mon Sep 17 00:00:00 2001 From: Adam Fraser Date: Mon, 30 Oct 2023 11:03:42 -0700 Subject: [PATCH 1/2] delete whitelist role --- src/clients/grant.rs | 4 +++- src/model.rs | 12 +----------- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/clients/grant.rs b/src/clients/grant.rs index f494862..98eade6 100644 --- a/src/clients/grant.rs +++ b/src/clients/grant.rs @@ -1,3 +1,5 @@ +use core::panic; + use async_trait::async_trait; use tracing::info; @@ -106,11 +108,11 @@ impl GrantClient for GrantClientLiv fn api_to_cli(role: golem_client::model::Role) -> Role { match role { golem_client::model::Role::Admin {} => Role::Admin, - golem_client::model::Role::WhitelistAdmin {} => Role::WhitelistAdmin, golem_client::model::Role::MarketingAdmin {} => Role::MarketingAdmin, golem_client::model::Role::ViewProject {} => Role::ViewProject, golem_client::model::Role::DeleteProject {} => Role::DeleteProject, golem_client::model::Role::CreateProject {} => Role::CreateProject, golem_client::model::Role::InstanceServer {} => Role::InstanceServer, + _ => panic!("Unknown role"), } } diff --git a/src/model.rs b/src/model.rs index 5fcdae1..8155a56 100644 --- a/src/model.rs +++ b/src/model.rs @@ -141,20 +141,13 @@ impl From for GolemError { let joined = errors.join(", "); GolemError(format!("Invalid request: {joined}")) } - LoginError::Status403 { .. } => { - let msg = indoc! {" - At the moment account creation is restricted. - None of your verified emails is whitelisted. - Please contact us to create an account. - "}; - GolemError(msg.to_string()) - } LoginError::Status500 { error } => { GolemError(format!("Internal server error on Login: {error}")) } LoginError::Status401 { error } => { GolemError(format!("External service call error on Login: {error}")) } + _ => GolemError(format!("Unexpected error on Login")), } } } @@ -550,7 +543,6 @@ pub enum TemplateIdOrName { #[derive(Copy, Clone, PartialEq, Eq, Debug, EnumIter, Serialize, Deserialize)] pub enum Role { Admin, - WhitelistAdmin, MarketingAdmin, ViewProject, DeleteProject, @@ -562,7 +554,6 @@ impl Display for Role { fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { let s = match self { Role::Admin => "Admin", - Role::WhitelistAdmin => "WhitelistAdmin", Role::MarketingAdmin => "MarketingAdmin", Role::ViewProject => "ViewProject", Role::DeleteProject => "DeleteProject", @@ -580,7 +571,6 @@ impl FromStr for Role { fn from_str(s: &str) -> Result { match s { "Admin" => Ok(Role::Admin), - "WhitelistAdmin" => Ok(Role::WhitelistAdmin), "MarketingAdmin" => Ok(Role::MarketingAdmin), "ViewProject" => Ok(Role::ViewProject), "DeleteProject" => Ok(Role::DeleteProject), From 8429b0979fb39f674f2b86351ecb515d9f889b3e Mon Sep 17 00:00:00 2001 From: Adam Fraser Date: Mon, 30 Oct 2023 11:12:18 -0700 Subject: [PATCH 2/2] clippy --- src/model.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/model.rs b/src/model.rs index 8155a56..d5c85f7 100644 --- a/src/model.rs +++ b/src/model.rs @@ -16,7 +16,6 @@ use golem_client::template::TemplateError; use golem_client::token::TokenError; use golem_client::worker::WorkerError; use golem_examples::model::{Example, ExampleName, GuestLanguage, GuestLanguageTier}; -use indoc::indoc; use serde::{Deserialize, Serialize}; use strum::IntoEnumIterator; use strum_macros::EnumIter; @@ -147,7 +146,7 @@ impl From for GolemError { LoginError::Status401 { error } => { GolemError(format!("External service call error on Login: {error}")) } - _ => GolemError(format!("Unexpected error on Login")), + _ => GolemError("Unexpected error on Login".to_string()), } } }